From: Jiri Slaby <jirislaby@kernel.org>
To: Pujin Shi <shipujin.t@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
hankinsea@gmail.com
Subject: Re: [PATCH] tty: serial: mvebu-uart: Remove unused variable 'ret'
Date: Wed, 30 Sep 2020 10:21:55 +0200 [thread overview]
Message-ID: <bfa595ba-52a1-aab7-d6c8-8af7607b3281@kernel.org> (raw)
In-Reply-To: <20200930081459.1269-1-shipujin.t@gmail.com>
On 30. 09. 20, 10:14, Pujin Shi wrote:
> 'ret' variable is now defined but not used in mvebu_uart_probe(),
> causing this warning:
>
> drivers/tty/serial/mvebu-uart.c: In function ‘mvebu_uart_probe’:
> drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable ‘ret’ [-Wunused-variable]
>
> Signed-off-by: Pujin Shi <shipujin.t@gmail.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
> drivers/tty/serial/mvebu-uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
> index 7443c0506eb4..118b29912289 100644
> --- a/drivers/tty/serial/mvebu-uart.c
> +++ b/drivers/tty/serial/mvebu-uart.c
> @@ -803,7 +803,7 @@ static int mvebu_uart_probe(struct platform_device *pdev)
> &pdev->dev);
> struct uart_port *port;
> struct mvebu_uart *mvuart;
> - int ret, id, irq;
> + int id, irq;
>
> if (!reg) {
> dev_err(&pdev->dev, "no registers defined\n");
>
thanks,
--
js
suse labs
next prev parent reply other threads:[~2020-09-30 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 8:14 [PATCH] tty: serial: mvebu-uart: Remove unused variable 'ret' Pujin Shi
2020-09-30 8:21 ` Jiri Slaby [this message]
2020-09-30 9:21 ` Greg Kroah-Hartman
2020-10-05 23:51 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfa595ba-52a1-aab7-d6c8-8af7607b3281@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hankinsea@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shipujin.t@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).