From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAD54C2D0A8 for ; Wed, 30 Sep 2020 08:21:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FE7A20738 for ; Wed, 30 Sep 2020 08:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601454119; bh=YtC6OHJZRnoQb9ivTJAFooq316weIEMz1orqA3uqhy8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=zXs5/M80XzVTiH1i8BcoijnLrhdVvVQ1LSWqDCxXmlhPTyS1fS7aKHybPaituvlk6 Z3yOW333piMAoMS6v4VXPx4tQ9a/88t2CwiN9LRptDJjpQ59ftj3J4+yYAQuFPFNMe 7KvDjdq/XdYvEhHgNheIUqqqueKQEiwHhlf1tXIk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725799AbgI3IV7 (ORCPT ); Wed, 30 Sep 2020 04:21:59 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:36625 "EHLO mail-ej1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbgI3IV6 (ORCPT ); Wed, 30 Sep 2020 04:21:58 -0400 Received: by mail-ej1-f68.google.com with SMTP id qp15so596118ejb.3; Wed, 30 Sep 2020 01:21:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AnmAiSuhryQgiuxCIfxiMUZ49Ib7mZfhe2r0FxsXtiE=; b=GtKPAZXKGPXwppctpag5iZuRloh9/fyKcCxqy4bhe9U3jwXoNYsg5Tf5eX+2C2/P+b pjE+J7kPwywHNqZhPcTyalxi13yyxu7JNFykkthO5gTsGYMiLgjru/jOi75nMVTSq27K +RB63Vt+HXFvYFMne0zFXXXRPPsq0XsshdNXtQA8p0m5oUUSXYDGy5ZCTa6dtfD+0nau lPFHSfLdbc0lyInXtduUU2z0ImQKN90ub/FARlximRnQpiEpAjPua846XF9HF57c8kK9 LLdlhd8agzd6NKc/WhhqSpKhYkAbHPwWh1D3Blj03Iy5yA5/kiacPT4/cgws+sZCHcP5 mitg== X-Gm-Message-State: AOAM532c4HnvWZzTGrvg8u72paR6RvtmCYEdzn9jC1tzYKZUapwqfNvl 8ue0wxECtjsbcedQQMjU/vA= X-Google-Smtp-Source: ABdhPJw6bec972tmVwZG7C2+NMX7qUMnT5frUQjSPPMYma2uOjjVneMUDze1KIu5PUu2+7riorwpWw== X-Received: by 2002:a17:906:7f15:: with SMTP id d21mr1674985ejr.470.1601454116954; Wed, 30 Sep 2020 01:21:56 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id j15sm925412ejs.5.2020.09.30.01.21.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Sep 2020 01:21:56 -0700 (PDT) Subject: Re: [PATCH] tty: serial: mvebu-uart: Remove unused variable 'ret' To: Pujin Shi , Greg Kroah-Hartman Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, hankinsea@gmail.com References: <20200930081459.1269-1-shipujin.t@gmail.com> From: Jiri Slaby Message-ID: Date: Wed, 30 Sep 2020 10:21:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200930081459.1269-1-shipujin.t@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On 30. 09. 20, 10:14, Pujin Shi wrote: > 'ret' variable is now defined but not used in mvebu_uart_probe(), > causing this warning: > > drivers/tty/serial/mvebu-uart.c: In function ‘mvebu_uart_probe’: > drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable ‘ret’ [-Wunused-variable] > > Signed-off-by: Pujin Shi Reviewed-by: Jiri Slaby > --- > drivers/tty/serial/mvebu-uart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c > index 7443c0506eb4..118b29912289 100644 > --- a/drivers/tty/serial/mvebu-uart.c > +++ b/drivers/tty/serial/mvebu-uart.c > @@ -803,7 +803,7 @@ static int mvebu_uart_probe(struct platform_device *pdev) > &pdev->dev); > struct uart_port *port; > struct mvebu_uart *mvuart; > - int ret, id, irq; > + int id, irq; > > if (!reg) { > dev_err(&pdev->dev, "no registers defined\n"); > thanks, -- js suse labs