From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jacky Huang <ychuang570808@gmail.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
lee@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
p.zabel@pengutronix.de, gregkh@linuxfoundation.org,
jirislaby@kernel.org
Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
schung@nuvoton.com, Jacky Huang <ychuang3@nuvoton.com>
Subject: Re: [PATCH 09/15] dt-bindings: reset: Document ma35d1 reset controller bindings
Date: Thu, 16 Mar 2023 08:37:49 +0100 [thread overview]
Message-ID: <cee0497e-c441-3937-07ec-0b6c4621f4e4@linaro.org> (raw)
In-Reply-To: <20230315072902.9298-10-ychuang570808@gmail.com>
On 15/03/2023 08:28, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@nuvoton.com>
>
> Add documentation to describe nuvoton ma35d1 reset driver bindings.
Subject: drop second/last, redundant "bindings". The "dt-bindings"
prefix is already stating that these are bindings.
>
> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
> ---
> .../bindings/reset/nuvoton,ma35d1-reset.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml
>
> diff --git a/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml
> new file mode 100644
> index 000000000000..f66c566c6dce
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/nuvoton,ma35d1-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton MA35D1 Reset Controller
> +
> +maintainers:
> + - Chi-Fang Li <cfli0@nuvoton.com>
> + - Jacky Huang <ychuang3@nuvoton.com>
> +
> +description:
> + The system reset controller can be used to reset various peripheral
> + controllers in MA35D1 SoC.
> +
> +properties:
> + compatible:
> + const: nuvoton,ma35d1-reset
> +
> + regmap:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Phandle to the register map node.
You need to be specific what is this. As you can easily check, there is
no such property in any devices. I don't understand why do you need it
in the first place.
> +
> + '#reset-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - regmap
> + - '#reset-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + # system reset controller node:
> + - |
> + #include <dt-bindings/reset/nuvoton,ma35d1-reset.h>
> +
> + sys: system-management@40460000 {
> + compatible = "nuvoton,ma35d1-sys", "syscon", "simple-mfd";
And your patchset is not bisectable.... Test for bisectability before
sending.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-16 7:38 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 7:28 [PATCH 00/15] Introduce Nuvoton ma35d1 SoC Jacky Huang
2023-03-15 7:28 ` [PATCH 01/15] arm64: Kconfig.platforms: Add config for Nuvoton MA35 platform Jacky Huang
2023-03-15 7:28 ` [PATCH 02/15] arm64: defconfig: Add Nuvoton MA35 family support Jacky Huang
2023-03-16 14:23 ` Arnd Bergmann
2023-03-17 9:05 ` Jacky Huang
2023-03-15 7:28 ` [PATCH 03/15] mfd: Add the header file of Nuvoton ma35d1 system manager Jacky Huang
2023-03-16 13:30 ` Ilpo Järvinen
2023-03-17 6:51 ` Jacky Huang
2023-03-16 14:44 ` Arnd Bergmann
2023-03-17 9:28 ` Jacky Huang
2023-03-15 7:28 ` [PATCH 04/15] dt-bindings: clock: nuvoton: add binding for ma35d1 clock controller Jacky Huang
2023-03-16 7:31 ` Krzysztof Kozlowski
2023-03-16 13:35 ` Jacky Huang
2023-03-16 14:09 ` Krzysztof Kozlowski
2023-03-15 7:28 ` [PATCH 05/15] dt-bindings: reset: nuvoton: add binding for ma35d1 IP reset control Jacky Huang
2023-03-16 7:31 ` Krzysztof Kozlowski
2023-03-15 7:28 ` [PATCH 06/15] dt-bindings: mfd: syscon: Add nuvoton,ma35d1-sys compatible Jacky Huang
2023-03-16 7:31 ` Krzysztof Kozlowski
2023-03-17 1:03 ` Jacky Huang
2023-03-15 7:28 ` [PATCH 07/15] dt-bindings: arm: Add initial bindings for Nuvoton platform Jacky Huang
2023-03-16 7:33 ` Krzysztof Kozlowski
2023-03-16 14:32 ` Arnd Bergmann
2023-03-18 1:26 ` Jacky Huang
2023-03-15 7:28 ` [PATCH 08/15] dt-bindings: clock: Document ma35d1 clock controller bindings Jacky Huang
2023-03-15 21:59 ` Stephen Boyd
2023-03-16 3:24 ` Jacky Huang
2023-03-16 7:35 ` Krzysztof Kozlowski
2023-03-17 3:47 ` Jacky Huang
2023-03-17 9:13 ` Krzysztof Kozlowski
2023-03-17 9:52 ` Jacky Huang
2023-03-17 16:03 ` Krzysztof Kozlowski
2023-03-18 2:11 ` Jacky Huang
2023-03-15 7:28 ` [PATCH 09/15] dt-bindings: reset: Document ma35d1 reset " Jacky Huang
2023-03-16 7:37 ` Krzysztof Kozlowski [this message]
2023-03-16 7:39 ` Krzysztof Kozlowski
2023-03-18 4:30 ` Jacky Huang
2023-03-19 11:05 ` Krzysztof Kozlowski
2023-03-20 6:26 ` Jacky Huang
2023-03-15 7:28 ` [PATCH 10/15] dt-bindings: serial: Document ma35d1 uart " Jacky Huang
2023-03-16 7:40 ` Krzysztof Kozlowski
2023-03-17 4:18 ` Jacky Huang
2023-03-15 7:28 ` [PATCH 11/15] arm64: dts: nuvoton: Add initial ma35d1 device tree Jacky Huang
2023-03-16 7:45 ` Krzysztof Kozlowski
2023-03-18 6:07 ` Jacky Huang
2023-03-19 11:06 ` Krzysztof Kozlowski
2023-03-19 14:16 ` Jacky Huang
2023-03-16 14:17 ` Arnd Bergmann
2023-03-16 16:44 ` Lee Jones
2023-03-18 13:32 ` Jacky Huang
2023-03-18 13:17 ` Jacky Huang
2023-03-18 14:04 ` Arnd Bergmann
2023-03-20 15:38 ` Jacky Huang
2023-03-15 7:28 ` [PATCH 12/15] clk: nuvoton: Add clock driver for ma35d1 clock controller Jacky Huang
2023-03-15 22:07 ` kernel test robot
2023-03-15 22:30 ` Stephen Boyd
2023-03-17 3:07 ` Jacky Huang
2023-03-16 7:51 ` Krzysztof Kozlowski
2023-03-19 2:55 ` Jacky Huang
2023-03-16 15:56 ` Ilpo Järvinen
2023-03-19 5:16 ` Jacky Huang
2023-03-20 10:31 ` Ilpo Järvinen
2023-03-21 15:03 ` Jacky Huang
2023-03-15 7:29 ` [PATCH 13/15] reset: Add Nuvoton ma35d1 reset driver support Jacky Huang
2023-03-16 7:51 ` Krzysztof Kozlowski
2023-03-17 7:13 ` Jacky Huang
2023-03-16 15:05 ` Ilpo Järvinen
2023-03-19 13:10 ` Jacky Huang
2023-03-15 7:29 ` [PATCH 14/15] tty: serial: Add Nuvoton ma35d1 serial " Jacky Huang
2023-03-15 7:37 ` Greg KH
2023-03-15 9:40 ` Jacky Huang
2023-03-15 9:48 ` kernel test robot
2023-03-15 10:13 ` Jiri Slaby
2023-03-16 13:28 ` Jacky Huang
2023-03-16 14:54 ` Ilpo Järvinen
2023-03-20 8:23 ` Jacky Huang
2023-03-20 10:04 ` Ilpo Järvinen
2023-03-21 14:23 ` Jacky Huang
2023-03-15 7:29 ` [PATCH 15/15] MAINTAINERS: Add entry for NUVOTON MA35 Jacky Huang
2023-03-16 14:38 ` Arnd Bergmann
2023-03-19 12:01 ` Jacky Huang
2023-03-19 12:36 ` Tomer Maimon
2023-03-16 7:41 ` [PATCH 00/15] Introduce Nuvoton ma35d1 SoC Krzysztof Kozlowski
2023-03-16 14:05 ` Arnd Bergmann
2023-03-17 6:30 ` Jacky Huang
2023-03-17 13:21 ` Arnd Bergmann
2023-03-17 16:06 ` Krzysztof Kozlowski
2023-03-18 3:07 ` Jacky Huang
2023-03-18 9:07 ` Arnd Bergmann
2023-03-18 3:00 ` Jacky Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cee0497e-c441-3937-07ec-0b6c4621f4e4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=schung@nuvoton.com \
--cc=ychuang3@nuvoton.com \
--cc=ychuang570808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).