From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF7BC433F5 for ; Wed, 10 Nov 2021 12:16:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6761661247 for ; Wed, 10 Nov 2021 12:16:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231336AbhKJMSy (ORCPT ); Wed, 10 Nov 2021 07:18:54 -0500 Received: from comms.puri.sm ([159.203.221.185]:47426 "EHLO comms.puri.sm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231229AbhKJMSx (ORCPT ); Wed, 10 Nov 2021 07:18:53 -0500 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 01291DFD9F; Wed, 10 Nov 2021 04:15:36 -0800 (PST) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zz40ZZMGPKYC; Wed, 10 Nov 2021 04:15:35 -0800 (PST) Message-ID: Subject: Re: [RFC 06/19] devfreq: imx8m-ddrc: Add late system sleep PM ops From: Martin Kepplinger To: Abel Vesa , Rob Herring , Dong Aisheng , Shawn Guo , Sascha Hauer , Fabio Estevam , "catalin.marinas@arm.com" , Will Deacon , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Georgi Djakov , Adrian Hunter , Ulf Hansson , Ahmad Fatoum Cc: Pengutronix Kernel Team , linux-serial@vger.kernel.org, NXP Linux Team , Linux Kernel Mailing List , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Wed, 10 Nov 2021 13:15:26 +0100 In-Reply-To: <1631554694-9599-7-git-send-email-abel.vesa@nxp.com> References: <1631554694-9599-1-git-send-email-abel.vesa@nxp.com> <1631554694-9599-7-git-send-email-abel.vesa@nxp.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Am Montag, dem 13.09.2021 um 20:38 +0300 schrieb Abel Vesa: > Seems that, in order to be able to resume from suspend, the dram rate > needs to be the highest one available. Therefore, add the late system > suspend/resume PM ops which set the highest rate on suspend and the > latest one used before suspending on resume. Hi Abel, wouldn't this mean that s2idle / freeze would be kind of broken by this? Does is make sense to test the lowest rate? How would I force that here? (just for testing) Also, you could think about splitting this series up a bit and do this patch seperately onto mainline (before or after the other work). thank you martin > > Signed-off-by: Abel Vesa > --- >  drivers/devfreq/imx8m-ddrc.c | 28 +++++++++++++++++++++++++++- >  1 file changed, 27 insertions(+), 1 deletion(-) > > diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m- > ddrc.c > index f18a5c3c1c03..f39741b4a0b0 100644 > --- a/drivers/devfreq/imx8m-ddrc.c > +++ b/drivers/devfreq/imx8m-ddrc.c > @@ -72,6 +72,8 @@ struct imx8m_ddrc { >         struct clk *dram_alt; >         struct clk *dram_apb; >   > +       unsigned long suspend_rate; > +       unsigned long resume_rate; >         int freq_count; >         struct imx8m_ddrc_freq freq_table[IMX8M_DDRC_MAX_FREQ_COUNT]; >  }; > @@ -271,6 +273,22 @@ static int imx8m_ddrc_target(struct device *dev, > unsigned long *freq, u32 flags) >         return ret; >  } >   > +static int imx8m_ddrc_suspend(struct device *dev) > +{ > +       struct imx8m_ddrc *priv = dev_get_drvdata(dev); > + > +       priv->resume_rate = clk_get_rate(priv->dram_core); > + > +       return imx8m_ddrc_target(dev, &priv->suspend_rate, 0); > +} > + > +static int imx8m_ddrc_resume(struct device *dev) > +{ > +       struct imx8m_ddrc *priv = dev_get_drvdata(dev); > + > +       return imx8m_ddrc_target(dev, &priv->resume_rate, 0); > +} > + >  static int imx8m_ddrc_get_cur_freq(struct device *dev, unsigned long > *freq) >  { >         struct imx8m_ddrc *priv = dev_get_drvdata(dev); > @@ -324,6 +342,9 @@ static int imx8m_ddrc_init_freq_info(struct > device *dev) >   >                 if (dev_pm_opp_add(dev, freq->rate * 250000, 0)) >                         return -ENODEV; > + > +               if (index ==  0) > +                       priv->suspend_rate = freq->rate * 250000; >         } >   >         return 0; > @@ -399,11 +420,16 @@ static const struct of_device_id > imx8m_ddrc_of_match[] = { >  }; >  MODULE_DEVICE_TABLE(of, imx8m_ddrc_of_match); >   > +static const struct dev_pm_ops imx8m_ddrc_pm_ops = { > +       SET_LATE_SYSTEM_SLEEP_PM_OPS(imx8m_ddrc_suspend, > imx8m_ddrc_resume) > +}; > + >  static struct platform_driver imx8m_ddrc_platdrv = { >         .probe          = imx8m_ddrc_probe, >         .driver = { >                 .name   = "imx8m-ddrc-devfreq", > -               .of_match_table = imx8m_ddrc_of_match, > +               .pm = &imx8m_ddrc_pm_ops, > +               .of_match_table = of_match_ptr(imx8m_ddrc_of_match), >         }, >  }; >  module_platform_driver(imx8m_ddrc_platdrv);