From: "Ivan Sistik - 3K Solutions, s. r. o." <sistik@3ksolutions.sk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Eric Anholt <eric@anholt.net>,
Stefan Wahren <stefan.wahren@i2se.com>,
Jiri Slaby <jslaby@suse.com>,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: serial: amba-pl011: added RS485 support
Date: Fri, 17 Jan 2020 01:31:48 +0100 [thread overview]
Message-ID: <f6deeb06-39b7-f140-c6bd-c977c5ad2b5a@3ksolutions.sk> (raw)
In-Reply-To: <20200107072748.GA1014453@kroah.com>
On 7. 1. 2020 at 8:27 Greg Kroah-Hartman wrote:
>> +config SERIAL_AMBA_PL011_SOFT_RS485
>> + bool "RS485 software direction switching for ARM AMBA PL011 serial"
>> + depends on SERIAL_AMBA_PL011=y
>
> Why "=y" here? Shouldn't this just read:
> depends on SERIAL_AMBA_PL011?
>
>> + select SERIAL_CORE
>
> Is this needed? SERIAL_AMBA_PL011 already selects this.
I am not sure. I found this few lines above:
> config SERIAL_AMBA_PL010_CONSOLE
> bool "Support for console on AMBA serial port"
> depends on SERIAL_AMBA_PL010=y
> select SERIAL_CORE_CONSOLE
and modified it for my purpose.
Thanks,
Ivan
next prev parent reply other threads:[~2020-01-17 0:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 23:52 [PATCH] tty: serial: amba-pl011: added RS485 support Ivan Sistik
2020-01-07 7:27 ` Greg Kroah-Hartman
2020-01-17 0:31 ` Ivan Sistik - 3K Solutions, s. r. o. [this message]
2020-01-07 7:28 ` Greg Kroah-Hartman
2020-01-16 13:29 ` Lukas Wunner
2020-01-17 0:58 ` Ivan Šištík - 3K Solutions, s. r. o.
2020-01-21 8:49 ` Lukas Wunner
2020-12-21 23:18 Ivan Sistik
2020-12-28 15:13 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6deeb06-39b7-f140-c6bd-c977c5ad2b5a@3ksolutions.sk \
--to=sistik@3ksolutions.sk \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).