From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B2F7C2BA80 for ; Tue, 7 Apr 2020 07:11:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DA7A2074F for ; Tue, 7 Apr 2020 07:11:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="fO6FXA6Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbgDGHLn (ORCPT ); Tue, 7 Apr 2020 03:11:43 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:41161 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbgDGHLn (ORCPT ); Tue, 7 Apr 2020 03:11:43 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586243502; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=E1R6nDQwxnv/zhYTF1086Nuhe2DWYwOBixad7z/PWBo=; b=fO6FXA6YPz7kE6iseC757rZWm+vYEukHF2PBTY+fZSmpnhA6zCHcKnrj2/MOM/FXxnsJVFUB M1+5LbUpLpQcxznM7BsmKP/kg8Pcff1KFg2llmOTjqxchefFQMzFO4ImPmEwEyC39kEddAM2 WIZXYMx1zYfpaadfffasdgnZY+Q= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyIzZmY0MiIsICJsaW51eC1zZXJpYWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e8c27a7.7f94c6768688-smtp-out-n03; Tue, 07 Apr 2020 07:11:35 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8739DC43636; Tue, 7 Apr 2020 07:11:34 +0000 (UTC) Received: from [192.168.0.6] (unknown [183.83.138.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: akashast) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1B410C433D2; Tue, 7 Apr 2020 07:11:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1B410C433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=akashast@codeaurora.org Subject: Re: [PATCH V3 5/8] spi: spi-geni-qcom: Add interconnect support To: Matthias Kaehlcke Cc: gregkh@linuxfoundation.org, agross@kernel.org, bjorn.andersson@linaro.org, wsa@the-dreams.de, broonie@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, georgi.djakov@linaro.org, linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, swboyd@chromium.org, mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, dianders@chromium.org, evgreen@chromium.org References: <1585652976-17481-1-git-send-email-akashast@codeaurora.org> <1585652976-17481-6-git-send-email-akashast@codeaurora.org> <20200331190249.GJ199755@google.com> From: Akash Asthana Message-ID: Date: Tue, 7 Apr 2020 12:41:19 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200331190249.GJ199755@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Hi Matthias, >> >> + ret = geni_icc_get(&mas->se, "qup-core", "qup-config", NULL); >> + if (ret) >> + goto spi_geni_probe_runtime_disable; > This fails without providing any hints why, besides the error code. > It might be worth to add error logging to geni_icc_get(). > As per Bjorn's comment, I will add error logs inside geni_icc_get API incase it returns something other than -EPROBE_DEFER . https://patchwork.kernel.org/patch/11467511/ regards, Akash -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project