From: Jethro Beekman <jethro@fortanix.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>,
"Xing, Cedric" <cedric.xing@intel.com>
Cc: "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>
Subject: Re: [RFC PATCH 2/4] x86/vdso: x86/sgx: Rework __vdso_sgx_enter_enclave() API
Date: Thu, 27 Aug 2020 10:58:47 +0200 [thread overview]
Message-ID: <18cacc82-af81-d00a-0542-d859bb116f5b@fortanix.com> (raw)
In-Reply-To: <20200826201511.GB21459@sjchrist-ice>
[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]
On 2020-08-26 22:15, Sean Christopherson wrote:
> On Wed, Aug 26, 2020 at 12:27:54PM -0700, Xing, Cedric wrote:
>> On 8/17/2020 9:24 PM, Sean Christopherson wrote:
>>> Rework __vdso_sgx_enter_enclave() to use a struct to hold the input and
>>> output params. In the new struct, add an opaque "user_data" that can be
>>> used to pass context across the vDSO, and an explicit "exit_reason" to
>>> avoid overloading the return value.
>>> In order to pass additional parameters to the exit handler, the exinfo
>> structure could be embedded in a user-defined structure while the handler
>> could pick it up using "container_of" macro. IMO the original interface was
>> neat and suffcient, and we are over-engineering it.
>
> container_of/offsetof shenanigans were my original suggestion as well.
> Nathaniel's argument is that using such tricks is less than pleasent in a
> Rust environment.
>
> https://lkml.kernel.org/r/CAOASepOFh-vOrNZEVDFrDSuHs+9GEzzpXUTG-fZMuyjWAkpRWw@mail.gmail.com
Just for the record I'm a Rust user and I have nothing against a solution that requires computing field offsets. As others have mentioned, assembly doesn't have facilities for this but it hasn't been a problem there.
--
Jethro Beekman | Fortanix
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4054 bytes --]
next prev parent reply other threads:[~2020-08-27 8:58 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 4:24 [RFC PATCH 0/4] x86/vdso: x86/sgx: Rework SGX vDSO API Sean Christopherson
2020-08-18 4:24 ` [RFC PATCH 1/4] x86/vdso: x86/sgx: Explicitly force 8-byte CMP for detecting user handler Sean Christopherson
2020-08-18 16:46 ` Jarkko Sakkinen
2020-08-20 11:13 ` Jethro Beekman
2020-08-18 4:24 ` [RFC PATCH 2/4] x86/vdso: x86/sgx: Rework __vdso_sgx_enter_enclave() API Sean Christopherson
2020-08-18 16:57 ` Jarkko Sakkinen
2020-08-20 11:23 ` Jethro Beekman
2020-08-24 13:36 ` Jethro Beekman
2020-08-24 19:49 ` Jarkko Sakkinen
2020-09-04 10:25 ` Sean Christopherson
2020-09-04 13:36 ` Jarkko Sakkinen
2020-09-04 16:01 ` Sean Christopherson
2020-08-24 23:54 ` Sean Christopherson
2020-08-25 7:36 ` Jethro Beekman
2020-08-25 7:38 ` Sean Christopherson
2020-08-25 7:41 ` Jethro Beekman
2020-08-26 20:16 ` Sean Christopherson
2020-08-26 19:27 ` Xing, Cedric
2020-08-26 20:15 ` Sean Christopherson
2020-08-26 23:26 ` Xing, Cedric
2020-09-04 9:52 ` Sean Christopherson
2020-08-27 8:58 ` Jethro Beekman [this message]
2020-08-26 20:20 ` Sean Christopherson
2020-08-26 20:55 ` Andy Lutomirski
2020-08-27 13:35 ` Jarkko Sakkinen
2020-08-18 4:24 ` [RFC PATCH 3/4] x86/vdso: x86/sgx: Introduce dedicated SGX exit reasons for vDSO Sean Christopherson
2020-08-18 16:58 ` Jarkko Sakkinen
2020-08-20 11:13 ` Jethro Beekman
2020-08-18 4:24 ` [RFC PATCH 4/4] x86/vdso: x86/sgx: Allow the user to exit the vDSO loop on interrupts Sean Christopherson
2020-08-18 17:00 ` Jarkko Sakkinen
2020-08-18 17:15 ` Andy Lutomirski
2020-08-18 17:31 ` Sean Christopherson
2020-08-18 19:05 ` Andy Lutomirski
2020-08-19 14:21 ` Jethro Beekman
2020-08-19 15:02 ` Andy Lutomirski
2020-08-20 11:20 ` Jethro Beekman
2020-08-20 17:44 ` Andy Lutomirski
2020-08-20 17:53 ` Jethro Beekman
2020-08-22 21:55 ` Andy Lutomirski
2020-08-24 13:36 ` Jethro Beekman
2020-08-26 18:32 ` Sean Christopherson
2020-08-26 19:09 ` Xing, Cedric
2020-08-27 8:57 ` Jethro Beekman
2020-08-20 11:13 ` Jethro Beekman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18cacc82-af81-d00a-0542-d859bb116f5b@fortanix.com \
--to=jethro@fortanix.com \
--cc=cedric.xing@intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).