From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Huang, Kai" <kai.huang@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"Svahn, Kai" <kai.svahn@intel.com>,
"nhorman@redhat.com" <nhorman@redhat.com>,
"Christopherson, Sean J" <sean.j.christopherson@intel.com>,
"josh@joshtriplett.org" <josh@joshtriplett.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"suresh.b.siddha@intel.com" <suresh.b.siddha@intel.com>,
"Ayoun, Serge" <serge.ayoun@intel.com>,
"Huang, Haitao" <haitao.huang@intel.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"npmccallum@redhat.com" <npmccallum@redhat.com>,
"rientjes@google.com" <rientjes@google.com>,
"luto@kernel.org" <luto@kernel.org>,
"Katz-zamir, Shay" <shay.katz-zamir@intel.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
"bp@alien8.de" <bp@alien8.de>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v19,RESEND 16/27] x86/sgx: Add the Linux SGX Enclave Driver
Date: Wed, 27 Mar 2019 07:02:58 +0200 [thread overview]
Message-ID: <20190327050258.GE15397@linux.intel.com> (raw)
In-Reply-To: <1553601688.17255.12.camel@intel.com>
On Tue, Mar 26, 2019 at 12:01:31PM +0000, Huang, Kai wrote:
> On Wed, 2019-03-20 at 18:21 +0200, Jarkko Sakkinen wrote:
> > Intel Software Guard eXtensions (SGX) is a set of CPU instructions that
> > can be used by applications to set aside private regions of code and
> > data. The code outside the enclave is disallowed to access the memory
> > inside the enclave by the CPU access control.
> >
> > This commit adds the Linux SGX Enclave Driver that provides an ioctl API
> > to manage enclaves. The address range for an enclave, commonly referred
> > as ELRANGE in the documentation (e.g. Intel SDM), is reserved with
> > mmap() against /dev/sgx. After that a set ioctls is used to build
> > the enclave to the ELRANGE.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Co-developed-by: Sean Christopherson <sean.j.christopherson@intel.com>
> > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> > Co-developed-by: Serge Ayoun <serge.ayoun@intel.com>
> > Signed-off-by: Serge Ayoun <serge.ayoun@intel.com>
> > Co-developed-by: Shay Katz-zamir <shay.katz-zamir@intel.com>
> > Signed-off-by: Shay Katz-zamir <shay.katz-zamir@intel.com>
> > Co-developed-by: Suresh Siddha <suresh.b.siddha@intel.com>
> > Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
> > ---
> > Documentation/ioctl/ioctl-number.txt | 1 +
> > arch/x86/Kconfig | 17 +-
> > arch/x86/include/uapi/asm/sgx.h | 59 ++
> > arch/x86/kernel/cpu/sgx/Makefile | 5 +-
> > arch/x86/kernel/cpu/sgx/driver/Makefile | 3 +
> > arch/x86/kernel/cpu/sgx/driver/driver.h | 38 ++
> > arch/x86/kernel/cpu/sgx/driver/ioctl.c | 795 ++++++++++++++++++++++++
> > arch/x86/kernel/cpu/sgx/driver/main.c | 290 +++++++++
> > arch/x86/kernel/cpu/sgx/encl.c | 358 +++++++++++
> > arch/x86/kernel/cpu/sgx/encl.h | 88 +++
> > arch/x86/kernel/cpu/sgx/encls.c | 1 +
> > arch/x86/kernel/cpu/sgx/main.c | 3 +
> > arch/x86/kernel/cpu/sgx/sgx.h | 1 +
> > 13 files changed, 1657 insertions(+), 2 deletions(-)
> > create mode 100644 arch/x86/include/uapi/asm/sgx.h
> > create mode 100644 arch/x86/kernel/cpu/sgx/driver/Makefile
> > create mode 100644 arch/x86/kernel/cpu/sgx/driver/driver.h
> > create mode 100644 arch/x86/kernel/cpu/sgx/driver/ioctl.c
> > create mode 100644 arch/x86/kernel/cpu/sgx/driver/main.c
> > create mode 100644 arch/x86/kernel/cpu/sgx/encl.c
> > create mode 100644 arch/x86/kernel/cpu/sgx/encl.h
>
> Shouldn't the driver be located somewhere under drivers/, but not under arch/x86?
>
> I don't think x86 maintainers should have the burden to review every code change made to SGX driver?
Not sure I got your angle. It is x86 tied code.
$ git grep tristate arch/x86/ | wc -l
22
/Jarkko
next prev parent reply other threads:[~2019-03-27 5:03 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 16:20 [PATCH v19,RESEND 00/27] Intel SGX1 support Jarkko Sakkinen
2019-03-20 16:20 ` [PATCH v19,RESEND 01/27] x86/cpufeatures: Add Intel-defined SGX feature bit Jarkko Sakkinen
2019-03-20 19:41 ` Neil Horman
2019-03-21 14:16 ` Jarkko Sakkinen
2019-03-20 16:20 ` [PATCH v19,RESEND 02/27] x86/cpufeatures: Add SGX sub-features (as Linux-defined bits) Jarkko Sakkinen
2019-03-20 16:20 ` [PATCH v19,RESEND 03/27] x86/msr: Add IA32_FEATURE_CONTROL.SGX_ENABLE definition Jarkko Sakkinen
2019-03-20 16:20 ` [PATCH v19,RESEND 04/27] x86/cpufeatures: Add Intel-defined SGX_LC feature bit Jarkko Sakkinen
2019-03-20 16:20 ` [PATCH v19,RESEND 05/27] x86/msr: Add SGX Launch Control MSR definitions Jarkko Sakkinen
2019-03-20 16:20 ` [PATCH v19,RESEND 06/27] x86/mm: x86/sgx: Add new 'PF_SGX' page fault error code bit Jarkko Sakkinen
2019-03-20 16:20 ` [PATCH v19,RESEND 07/27] x86/mm: x86/sgx: Signal SIGSEGV for userspace #PFs w/ PF_SGX Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 08/27] x86/cpu/intel: Detect SGX support and update caps appropriately Jarkko Sakkinen
2019-03-26 12:17 ` Huang, Kai
2019-03-26 14:27 ` Sean Christopherson
2019-03-26 21:25 ` Huang, Kai
2019-03-26 21:57 ` Sean Christopherson
2019-03-26 23:19 ` Huang, Kai
2019-03-20 16:21 ` [PATCH v19,RESEND 09/27] x86/sgx: Add ENCLS architectural error codes Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 10/27] x86/sgx: Add SGX1 and SGX2 architectural data structures Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 11/27] x86/sgx: Add definitions for SGX's CPUID leaf and variable sub-leafs Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 12/27] x86/sgx: Enumerate and track EPC sections Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 13/27] x86/sgx: Add wrappers for ENCLS leaf functions Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 14/27] x86/sgx: Add functions to allocate and free EPC pages Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 15/27] x86/sgx: Add sgx_einit() for initializing enclaves Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 16/27] x86/sgx: Add the Linux SGX Enclave Driver Jarkko Sakkinen
2019-03-26 12:01 ` Huang, Kai
2019-03-26 12:40 ` Thomas Gleixner
2019-03-26 14:54 ` Sean Christopherson
2019-03-26 21:11 ` Huang, Kai
2019-03-27 5:02 ` Jarkko Sakkinen [this message]
2019-03-20 16:21 ` [PATCH v19,RESEND 17/27] x86/sgx: Add provisioning Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 18/27] x86/sgx: Add swapping code to the core and SGX driver Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 19/27] x86/sgx: ptrace() support for the " Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 20/27] x86/vdso: Add support for exception fixup in vDSO functions Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 21/27] x86/fault: Add helper function to sanitize error code Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 22/27] x86/fault: Attempt to fixup unhandled #PF in vDSO before signaling Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 23/27] x86/traps: Attempt to fixup exceptions " Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 24/27] x86/vdso: Add __vdso_sgx_enter_enclave() to wrap SGX enclave transitions Jarkko Sakkinen
2019-03-20 18:30 ` Xing, Cedric
2019-03-20 18:52 ` Andy Lutomirski
2019-03-20 19:57 ` Xing, Cedric
2019-03-20 21:03 ` Sean Christopherson
2019-03-21 0:17 ` Xing, Cedric
2019-03-22 21:20 ` Sean Christopherson
2019-03-21 17:17 ` Andy Lutomirski
2019-03-22 20:31 ` Xing, Cedric
2019-03-20 19:02 ` Jethro Beekman
2019-03-20 20:10 ` Xing, Cedric
2019-03-20 19:13 ` Sean Christopherson
2019-03-20 20:38 ` Xing, Cedric
2019-03-22 21:59 ` Sean Christopherson
2019-03-23 17:36 ` Xing, Cedric
2019-03-23 21:38 ` Andy Lutomirski
2019-03-24 8:59 ` Xing, Cedric
2019-03-25 18:03 ` Sean Christopherson
2019-03-25 23:59 ` Andy Lutomirski
2019-03-26 4:53 ` Xing, Cedric
2019-03-26 17:08 ` Andy Lutomirski
2019-03-28 4:23 ` Xing, Cedric
2019-03-28 19:18 ` Andy Lutomirski
2019-03-28 23:19 ` Xing, Cedric
2019-03-29 9:48 ` Jarkko Sakkinen
2019-03-31 8:43 ` Dr. Greg
2019-04-03 23:03 ` Sean Christopherson
2019-03-25 23:54 ` Andy Lutomirski
2019-03-26 4:16 ` Xing, Cedric
2019-03-20 16:21 ` [PATCH v19,RESEND 25/27] x86/sgx: SGX documentation Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 26/27] selftests/x86: Add a selftest for SGX Jarkko Sakkinen
2019-03-20 16:21 ` [PATCH v19,RESEND 27/27] x86/sgx: Update MAINTAINERS Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327050258.GE15397@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=haitao.huang@intel.com \
--cc=josh@joshtriplett.org \
--cc=kai.huang@intel.com \
--cc=kai.svahn@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=nhorman@redhat.com \
--cc=npmccallum@redhat.com \
--cc=rientjes@google.com \
--cc=sean.j.christopherson@intel.com \
--cc=serge.ayoun@intel.com \
--cc=shay.katz-zamir@intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).