From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8634DC31E40 for ; Sat, 10 Aug 2019 00:03:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61C9B2166E for ; Sat, 10 Aug 2019 00:03:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726189AbfHJAD5 (ORCPT ); Fri, 9 Aug 2019 20:03:57 -0400 Received: from mga09.intel.com ([134.134.136.24]:62358 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbfHJAD4 (ORCPT ); Fri, 9 Aug 2019 20:03:56 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2019 17:03:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,367,1559545200"; d="scan'208";a="204080493" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga002.fm.intel.com with ESMTP; 09 Aug 2019 17:03:55 -0700 Date: Fri, 9 Aug 2019 17:03:55 -0700 From: Sean Christopherson To: Jarkko Sakkinen Cc: linux-sgx@vger.kernel.org, Shay Katz-zamir , Serge Ayoun Subject: Re: [PATCH for_v22 07/11] x86/sgx: Check that enclave is created at beginning of EADD/EINIT ioctl Message-ID: <20190810000355.GI10541@linux.intel.com> References: <20190808001254.11926-1-sean.j.christopherson@intel.com> <20190808001254.11926-8-sean.j.christopherson@intel.com> <20190809234032.kntlqgnyfenf6b7j@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190809234032.kntlqgnyfenf6b7j@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-sgx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Sat, Aug 10, 2019 at 02:40:32AM +0300, Jarkko Sakkinen wrote: > On Wed, Aug 07, 2019 at 05:12:50PM -0700, Sean Christopherson wrote: > > Move the EADD/EINIT checks on SGX_ENCL_CREATED to the very beginning of > > the ioctl() flows. Deferring the check until the core code is fragile > > as all code leading up to that point must be careful that it only uses > > members of @encl that are initialized at allocation time. For example, > > the flush_work() call in sgx_encl_init() will crash if the enclave has > > not been created. > > > > Note, there is no need to take encl->lock to check SGX_ENCL_CREATED so > > long as SGX_ENCL_CREATED is set only after the enclave is fully > > initialized, it's not the kernel's responsibility to guard against > > sgx_encl_create() racing with EADD/EINIT. Add a comment to highlight > > the dependency. > > > > Signed-off-by: Sean Christopherson > > 07/11, 08/11 and 09/11 have been squashed and pushed. > > I'm now observing this kind of behavior with the self-test: > > jsakkine at jsakkine-lab2 in ~/devel/linux-sgx (master●) > $ sudo tools/testing/selftests/x86/sgx/test_sgx > Binary size 24576 (0x6000), SIGSTRUCT size 1808 > Loading the enclave. > ECREATE failed rc=-1, err=22. Doh, I forgot to update/test the selftest. I'll do so now.