From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-sgx@vger.kernel.org
Subject: Re: [PATCH] x86/sgx: Return 0 when !CONFIG_INTEL_SGX_DRIVER
Date: Wed, 21 Aug 2019 10:24:00 -0700 [thread overview]
Message-ID: <20190821172400.GH29345@linux.intel.com> (raw)
In-Reply-To: <20190815215600.u3cz27y27nrldq3i@linux.intel.com>
On Fri, Aug 16, 2019 at 12:56:00AM +0300, Jarkko Sakkinen wrote:
> On Mon, Aug 12, 2019 at 06:22:27PM -0700, Sean Christopherson wrote:
> > Nope, KVM does not have any dependencies on the native driver. But if
> > sgx_drv_init() returns 0 when CONFIG_INTEL_SGX_DRIVER=n, then sgx_init()
> > won't handle KVM failure correctly since it will think the native driver
> > initialized cleanly. E.g. with both KVM and driver in play, I was
> > thinking of something like this in sgx_init():
> >
> > /* Success if the native *or* virtual driver initialized cleanly. */
> > ret = sgx_drv_init();
> > ret = sgx_virt_epc_init() ? ret : 0;
> > if (ret)
> > goto err;
> >
> > return 0;
> >
> > If sgx_drv_init() returns 0 when CONFIG_INTEL_SGX_DRIVER=n, then failure
> > in sgx_virt_epc_init() is ignored and we end up with the SGX subsystem
> > wasting resources again.
>
> I get what you are saying but what exist now does not align with this
> and on the other hand nothing prevents the reconsider the flow once we
> get to this point.
How does the current code not align with this approach? The core subsystem
should tear itself down if loading the driver fails, which includes failing
because it doesn't exist.
next prev parent reply other threads:[~2019-08-21 17:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 14:32 [PATCH] x86/sgx: Return 0 when !CONFIG_INTEL_SGX_DRIVER Jarkko Sakkinen
2019-07-15 9:29 ` Jarkko Sakkinen
2019-07-15 13:59 ` Sean Christopherson
2019-08-01 16:22 ` Jarkko Sakkinen
2019-08-01 16:29 ` Sean Christopherson
2019-08-02 19:33 ` Jarkko Sakkinen
2019-08-13 1:22 ` Sean Christopherson
2019-08-15 21:56 ` Jarkko Sakkinen
2019-08-21 17:24 ` Sean Christopherson [this message]
2019-08-22 0:29 ` Jarkko Sakkinen
2019-08-22 0:31 ` Sean Christopherson
2019-08-22 14:42 ` Jarkko Sakkinen
2019-08-22 1:26 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821172400.GH29345@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-sgx@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).