From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: sean.j.christopherson@intel.com
Cc: luto@kernel.org, linux-sgx@vger.kernel.org
Subject: sgx_encl_may_map()
Date: Fri, 23 Aug 2019 18:02:48 +0300 [thread overview]
Message-ID: <20190823150248.kuxgdxyd4z5wlsz5@linux.intel.com> (raw)
Hi
Couple of remarks that are not reasoned in the code too well:
1. Why to allow to mmap() to a range where pages have differing
permissions? I think it would be better just to require all
pages in a range to have the same permissions.
2. Why not require exact match with the PROT bits?
3. Why don't just store SECINFO flags on EADD? Doing
calc_vma_prot_bits() on fly is not expensive. Now
data in SECINFO flags is scattered to two different
fields (desc and vm_max_prot_bits). I'd just have a field
called secinfo_flags.
This came up when I noted that SGX_IOC_ENCLAVE_ADD_PAGE documentation
was not updated when this permission handling came up. I started to
do it but stumped into these questions. I also wonder why the API
documentation has not been updated...
/Jarkko
next reply other threads:[~2019-08-23 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 15:02 Jarkko Sakkinen [this message]
2019-08-23 16:04 ` sgx_encl_may_map() Jarkko Sakkinen
2019-08-23 16:27 ` sgx_encl_may_map() Jarkko Sakkinen
2019-08-23 20:37 ` sgx_encl_may_map() Sean Christopherson
2019-08-26 2:56 ` sgx_encl_may_map() Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823150248.kuxgdxyd4z5wlsz5@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).