From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Ayoun, Serge" <serge.ayoun@intel.com>
Cc: "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"Christopherson, Sean J" <sean.j.christopherson@intel.com>,
"Katz-zamir, Shay" <shay.katz-zamir@intel.com>
Subject: Re: [PATCH 1/4] x86/sgx: Replace @is_secs_child with @pt in sgx_encl_ewb()
Date: Mon, 26 Aug 2019 19:25:33 +0300 [thread overview]
Message-ID: <20190826162533.4eojvetcaxhjbmhk@linux.intel.com> (raw)
In-Reply-To: <88B7642769729B409B4A93D7C5E0C5E7C6624865@hasmsx108.ger.corp.intel.com>
On Mon, Aug 26, 2019 at 02:31:54PM +0000, Ayoun, Serge wrote:
> Not sure about this one since this 'if' should never happen, unless there is a bug
> Not clear if the caller (sgx_encl_ewb) will handle -EINVAL properly.
> Maybe would be better to issue some warning message or BUG_ON
The caller issues warning.
/Jarkko
next prev parent reply other threads:[~2019-08-26 16:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 16:16 [PATCH 0/4] Remaining updates for v22 Jarkko Sakkinen
2019-08-23 16:16 ` [PATCH 1/4] x86/sgx: Replace @is_secs_child with @pt in sgx_encl_ewb() Jarkko Sakkinen
2019-08-26 14:31 ` Ayoun, Serge
2019-08-26 16:25 ` Jarkko Sakkinen [this message]
2019-08-23 16:16 ` [PATCH 2/4] x86/sgx: Validate TCS permssions in sgx_validate_secinfo() Jarkko Sakkinen
2019-08-23 16:16 ` [PATCH 3/4] x86/sgx: Remove a deperecated enum Jarkko Sakkinen
2019-08-23 16:16 ` [PATCH 4/4] x86/sgx: Move VM prot bits calculation to sgx_encl_page_alloc() Jarkko Sakkinen
2019-08-23 21:53 ` [PATCH 0/4] Remaining updates for v22 Sean Christopherson
2019-08-26 5:39 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826162533.4eojvetcaxhjbmhk@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=serge.ayoun@intel.com \
--cc=shay.katz-zamir@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).