From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-sgx@vger.kernel.org
Subject: [PATCH v3 5/5] x86/sgx: Destroy the enclave if EEXTEND fails
Date: Thu, 29 Aug 2019 17:17:06 -0700 [thread overview]
Message-ID: <20190830001706.29309-6-sean.j.christopherson@intel.com> (raw)
In-Reply-To: <20190830001706.29309-1-sean.j.christopherson@intel.com>
Mark an enclave as dead and release its resources if EEXTEND fails, as
the driver cannot gracefully unwind from EEXTEND failure and does not
provide userspace enough information to restart the ioctl. Allowing
EEXTEND to be restarted is not a requirement as EEXTEND can only fail in
the event of a kernel or hardware bug.
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
---
arch/x86/kernel/cpu/sgx/ioctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/cpu/sgx/ioctl.c b/arch/x86/kernel/cpu/sgx/ioctl.c
index 3800281c5945..fffdf25ee3f9 100644
--- a/arch/x86/kernel/cpu/sgx/ioctl.c
+++ b/arch/x86/kernel/cpu/sgx/ioctl.c
@@ -349,6 +349,7 @@ static int __sgx_encl_extend(struct sgx_encl *encl,
if (ret) {
if (encls_failed(ret))
ENCLS_WARN(ret, "EEXTEND");
+ sgx_encl_destroy(encl);
return -EFAULT;
}
}
--
2.22.0
next prev parent reply other threads:[~2019-08-30 0:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 0:17 [PATCH v3 0/5] x86/sgx: Fix lock ordering bug w/ EADD Sean Christopherson
2019-08-30 0:17 ` [PATCH v3 1/5] x86/sgx: Convert encl->flags from an unsigned int to an atomic Sean Christopherson
2019-08-30 0:17 ` [PATCH v3 2/5] x86/sgx: Reject concurrent ioctls on single enclave Sean Christopherson
2019-08-30 15:40 ` Jarkko Sakkinen
2019-08-30 0:17 ` [PATCH v3 3/5] x86/sgx: Take encl->lock inside of mm->mmap_sem for EADD Sean Christopherson
2019-08-30 0:17 ` [PATCH v3 4/5] x86/sgx: Reject all ioctls on dead enclaves Sean Christopherson
2019-08-30 0:17 ` Sean Christopherson [this message]
2019-08-30 16:16 ` [PATCH v3 0/5] x86/sgx: Fix lock ordering bug w/ EADD Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830001706.29309-6-sean.j.christopherson@intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-sgx@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).