From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-sgx@vger.kernel.org
Subject: [PATCH for_v23 7/7] selftests/x86/sgx: Add test coverage for reclaim and replicate
Date: Tue, 8 Oct 2019 21:42:41 -0700 [thread overview]
Message-ID: <20191009044241.3591-8-sean.j.christopherson@intel.com> (raw)
In-Reply-To: <20191009044241.3591-1-sean.j.christopherson@intel.com>
Pad 2*epc_size bytes to the end of the selftest enclave to test basic
reclaim functionality, and use the new replicate flag when adding the
pages.
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
---
tools/testing/selftests/x86/sgx/defines.h | 28 +++++++++++++++++++++++
tools/testing/selftests/x86/sgx/main.c | 8 ++++++-
tools/testing/selftests/x86/sgx/sgxsign.c | 20 ++++++++++++++--
3 files changed, 53 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/x86/sgx/defines.h b/tools/testing/selftests/x86/sgx/defines.h
index 3ff73a9d9b93..8d7b19b7e658 100644
--- a/tools/testing/selftests/x86/sgx/defines.h
+++ b/tools/testing/selftests/x86/sgx/defines.h
@@ -36,4 +36,32 @@ typedef uint64_t u64;
#include "../../../../../arch/x86/kernel/cpu/sgx/arch.h"
#include "../../../../../arch/x86/include/uapi/asm/sgx.h"
+/* Used to tack on unused data to the enclave to test reclaim and replicate. */
+#define SGX_SELFTEST_FILL_VALUE 0xcc
+
+static inline uint64_t get_epc_size(void)
+{
+ uint32_t eax, ebx, ecx, edx;
+ uint64_t size = 0;
+ int i;
+
+ for (i = 2; ; i++) {
+ asm volatile("cpuid"
+ : "=a"(eax), "=b"(ebx), "=c"(ecx), "=d"(edx)
+ : "a"(0x12), "c"(i));
+
+ if ((eax & SGX_CPUID_SUB_LEAF_TYPE_MASK) !=
+ SGX_CPUID_SUB_LEAF_EPC_SECTION)
+ break;
+
+ size += ((ecx & 0xfffff000UL) | ((uint64_t)edx << 32));
+ }
+ return size;
+}
+
+static inline uint64_t get_fill_size(void)
+{
+ return get_epc_size() * 2;
+}
+
#endif /* TYPES_H */
diff --git a/tools/testing/selftests/x86/sgx/main.c b/tools/testing/selftests/x86/sgx/main.c
index 0921aeda9942..d179b536d007 100644
--- a/tools/testing/selftests/x86/sgx/main.c
+++ b/tools/testing/selftests/x86/sgx/main.c
@@ -198,6 +198,8 @@ static bool encl_add_pages(int dev_fd, unsigned long offset, void *data,
static bool encl_build(struct sgx_secs *secs, void *bin,
unsigned long bin_size, struct sgx_sigstruct *sigstruct)
{
+ uint8_t fill_page[PAGE_SIZE] __aligned(4096);
+ uint64_t fill_size = get_fill_size();
struct sgx_enclave_init ioc;
void *addr;
int dev_fd;
@@ -209,12 +211,16 @@ static bool encl_build(struct sgx_secs *secs, void *bin,
return false;
}
- if (!encl_create(dev_fd, bin_size, secs))
+ if (!encl_create(dev_fd, bin_size + fill_size, secs))
goto out_dev_fd;
+ memset(fill_page, SGX_SELFTEST_FILL_VALUE, PAGE_SIZE);
+
encl_add_pages(dev_fd, 0, bin, 1, SGX_SECINFO_TCS, 0);
encl_add_pages(dev_fd, PAGE_SIZE, bin + PAGE_SIZE,
(bin_size / PAGE_SIZE) - 1, SGX_REG_PAGE_FLAGS, 0);
+ encl_add_pages(dev_fd, bin_size, fill_page, fill_size / PAGE_SIZE,
+ SGX_REG_PAGE_FLAGS, SGX_ADD_PAGES_REPLICATE_SRC);
ioc.sigstruct = (uint64_t)sigstruct;
rc = ioctl(dev_fd, SGX_IOC_ENCLAVE_INIT, &ioc);
diff --git a/tools/testing/selftests/x86/sgx/sgxsign.c b/tools/testing/selftests/x86/sgx/sgxsign.c
index 3d9007af40c9..98dee0d4b376 100644
--- a/tools/testing/selftests/x86/sgx/sgxsign.c
+++ b/tools/testing/selftests/x86/sgx/sgxsign.c
@@ -231,8 +231,9 @@ static bool measure_encl(const char *path, uint8_t *mrenclave)
struct stat sb;
EVP_MD_CTX *ctx;
uint64_t flags;
- uint64_t offset;
+ uint64_t offset, i;
uint8_t data[0x1000];
+ uint64_t fill_size;
int rc;
ctx = EVP_MD_CTX_create();
@@ -257,7 +258,9 @@ static bool measure_encl(const char *path, uint8_t *mrenclave)
goto out;
}
- if (!mrenclave_ecreate(ctx, sb.st_size))
+ fill_size = get_fill_size();
+
+ if (!mrenclave_ecreate(ctx, sb.st_size + fill_size))
goto out;
for (offset = 0; offset < sb.st_size; offset += 0x1000) {
@@ -280,6 +283,19 @@ static bool measure_encl(const char *path, uint8_t *mrenclave)
goto out;
}
+ memset(data, SGX_SELFTEST_FILL_VALUE, 0x1000);
+
+ for (i = 0; i < fill_size; i += 0x1000) {
+ flags = SGX_SECINFO_REG |
+ SGX_SECINFO_R | SGX_SECINFO_W | SGX_SECINFO_X;
+
+ if (!mrenclave_eadd(ctx, offset + i, flags))
+ goto out;
+
+ if (!mrenclave_eextend(ctx, offset + i, data))
+ goto out;
+ }
+
if (!mrenclave_commit(ctx, mrenclave))
goto out;
--
2.22.0
next prev parent reply other threads:[~2019-10-09 4:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 4:42 [PATCH for_v23 0/7] x86/sgx: Improve add pages ioctl Sean Christopherson
2019-10-09 4:42 ` [PATCH for_v23 1/7] x86/sgx: Modify ADD_PAGE ioctl to take offset instead of full address Sean Christopherson
2019-10-09 4:42 ` [PATCH for_v23 2/7] selftests/x86/sgx: Update test to account for ADD_PAGE change Sean Christopherson
2019-10-09 4:42 ` [PATCH for_v23 3/7] x86/sgx: Tweak ADD_PAGE ioctl to allow adding multiple pages Sean Christopherson
2019-10-14 21:32 ` Jarkko Sakkinen
2019-10-14 21:35 ` Jarkko Sakkinen
2019-10-14 23:31 ` Sean Christopherson
2019-10-16 10:17 ` Jarkko Sakkinen
2019-10-16 10:19 ` Jarkko Sakkinen
2019-10-16 10:29 ` Jarkko Sakkinen
2019-10-21 11:24 ` Jarkko Sakkinen
2019-10-09 4:42 ` [PATCH for_v23 4/7] selftests/x86/sgx: Update enclave build flow to do multi-page add Sean Christopherson
2019-10-09 4:42 ` [PATCH for_v23 5/7] x86/sgx: Add a flag to ADD_PAGES to allow replicating the source page Sean Christopherson
2019-10-09 4:42 ` [PATCH for_v23 6/7] selftests/x86/sgx: Update selftest to account for ADD_PAGES flag Sean Christopherson
2019-10-09 4:42 ` Sean Christopherson [this message]
2019-10-10 3:28 ` [PATCH for_v23 0/7] x86/sgx: Improve add pages ioctl Haitao Huang
2019-10-11 14:37 ` Sean Christopherson
2019-10-13 15:15 ` Dr. Greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009044241.3591-8-sean.j.christopherson@intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-sgx@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).