From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: linux-sgx@vger.kernel.org
Subject: Re: [PATCH for_v23 00/16] x86/vdso: sgx: Major vDSO cleanup
Date: Thu, 10 Oct 2019 11:10:19 +0300 [thread overview]
Message-ID: <20191010081019.GA20654@linux.intel.com> (raw)
In-Reply-To: <20191008044613.12350-1-sean.j.christopherson@intel.com>
On Mon, Oct 07, 2019 at 09:45:57PM -0700, Sean Christopherson wrote:
> The main purpose of this series is to implement feedback from the original
> RFC to expand the vDSO[*] that went unaddressed before the expanded
> function was rushed into v21.
>
> The other half of the series is to overhaul the selftest to actually test
> the exit handler variation of the vDSO, with a bunch of prework to add an
> assertion framework to standardize the various assertions in the test and
> improve the readability of the code.
>
> The basic ideas for the exit handler subtests are from Cedric's original
> RFC, but rewritten from scratch to take advantage of the new assertion
> framework. I haven't yet implemented single-step subtest, ideally that
> too will get done before v23.
>
> [*] https://lkml.kernel.org/r/20190426210017.GA24467@linux.intel.com
>
> Sean Christopherson (16):
> x86/vdso: sgx: Drop the pseudocode "documentation"
> x86/vdso: sgx: Do not use exception info to pass success/failure
> x86/vdso: sgx: Rename the enclave exit handler typedef
> x86/vdso: sgx: Move enclave exit handler declaration to UAPI header
> x86/vdso: sgx: Add comment regarding kernel-doc shenanigans
> x86/vdso: sgx: Rewrite __vdso_sgx_enter_enclave() function comment
> selftests/x86: Fix linker warning in SGX selftest
> selftests/x86/sgx: Use getauxval() to retrieve the vDSO base address
> selftests/x86/sgx: Add helper function and macros to assert results
> selftests/x86/sgx: Handle setup failures via test assertions
> selftests/x86/sgx: Sanitize the types for sgx_call()'s input params
> selftests/x86/sgx: Move existing sub-test to a separate helper
> selftests/x86/sgx: Add a test of the vDSO exception reporting
> mechanism
> selftests/x86/sgx: Add test of vDSO with basic exit handler
> selftests/x86/sgx: Add sub-test for exception behavior with exit
> handler
> x86/vdso: sgx: Rework __vdso_sgx_enter_enclave() to prefer "no
> callback"
>
> arch/x86/entry/vdso/vsgx_enter_enclave.S | 228 +++++++------
> arch/x86/include/uapi/asm/sgx.h | 18 +
> tools/testing/selftests/x86/sgx/Makefile | 2 +-
> tools/testing/selftests/x86/sgx/defines.h | 6 +
> tools/testing/selftests/x86/sgx/main.c | 384 ++++++++++++++--------
> 5 files changed, 387 insertions(+), 251 deletions(-)
>
> --
> 2.22.0
>
vDSO changes look legit. I might do some minor edits (like coding
style tweaks only). Thanks.
/Jarkko
next prev parent reply other threads:[~2019-10-10 8:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 4:45 [PATCH for_v23 00/16] x86/vdso: sgx: Major vDSO cleanup Sean Christopherson
2019-10-08 4:45 ` [PATCH for_v23 01/16] x86/vdso: sgx: Drop the pseudocode "documentation" Sean Christopherson
2019-10-08 4:45 ` [PATCH for_v23 02/16] x86/vdso: sgx: Do not use exception info to pass success/failure Sean Christopherson
2019-10-08 4:46 ` [PATCH for_v23 03/16] x86/vdso: sgx: Rename the enclave exit handler typedef Sean Christopherson
2019-10-08 4:46 ` [PATCH for_v23 04/16] x86/vdso: sgx: Move enclave exit handler declaration to UAPI header Sean Christopherson
2019-10-08 4:46 ` [PATCH for_v23 05/16] x86/vdso: sgx: Add comment regarding kernel-doc shenanigans Sean Christopherson
2019-10-08 4:46 ` [PATCH for_v23 06/16] x86/vdso: sgx: Rewrite __vdso_sgx_enter_enclave() function comment Sean Christopherson
2019-10-08 4:46 ` [PATCH for_v23 07/16] selftests/x86: Fix linker warning in SGX selftest Sean Christopherson
2019-10-08 4:46 ` [PATCH for_v23 08/16] selftests/x86/sgx: Use getauxval() to retrieve the vDSO base address Sean Christopherson
2019-10-08 4:46 ` [PATCH for_v23 09/16] selftests/x86/sgx: Add helper function and macros to assert results Sean Christopherson
2019-10-08 4:46 ` [PATCH for_v23 10/16] selftests/x86/sgx: Handle setup failures via test assertions Sean Christopherson
2019-10-15 10:16 ` Jarkko Sakkinen
2019-10-15 10:24 ` Jarkko Sakkinen
2019-10-15 10:25 ` Jarkko Sakkinen
2019-10-15 11:03 ` Jarkko Sakkinen
2019-10-15 16:27 ` Sean Christopherson
2019-10-16 10:20 ` Jarkko Sakkinen
2019-10-16 20:21 ` Sean Christopherson
2019-10-15 16:18 ` Sean Christopherson
2019-10-16 10:19 ` Jarkko Sakkinen
2019-10-08 4:46 ` [PATCH for_v23 11/16] selftests/x86/sgx: Sanitize the types for sgx_call()'s input params Sean Christopherson
2019-10-08 4:46 ` [PATCH for_v23 12/16] selftests/x86/sgx: Move existing sub-test to a separate helper Sean Christopherson
2019-10-08 4:46 ` [PATCH for_v23 13/16] selftests/x86/sgx: Add a test of the vDSO exception reporting mechanism Sean Christopherson
2019-10-08 4:46 ` [PATCH for_v23 14/16] selftests/x86/sgx: Add test of vDSO with basic exit handler Sean Christopherson
2019-10-08 4:46 ` [PATCH for_v23 15/16] selftests/x86/sgx: Add sub-test for exception behavior with " Sean Christopherson
2019-10-08 4:46 ` [PATCH for_v23 16/16] x86/vdso: sgx: Rework __vdso_sgx_enter_enclave() to prefer "no callback" Sean Christopherson
2019-10-09 18:00 ` Xing, Cedric
2019-10-09 19:10 ` Sean Christopherson
2019-10-10 0:21 ` Sean Christopherson
2019-10-10 17:49 ` Xing, Cedric
2019-10-10 23:59 ` Sean Christopherson
2019-10-16 22:18 ` Xing, Cedric
2019-10-16 22:53 ` Sean Christopherson
2019-10-10 8:10 ` Jarkko Sakkinen [this message]
2019-10-10 16:08 ` [PATCH for_v23 00/16] x86/vdso: sgx: Major vDSO cleanup Sean Christopherson
2019-10-14 21:04 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010081019.GA20654@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).