linux-sgx.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-sgx@vger.kernel.org
Subject: Re: [PATCH 2/2] selftests/x86/sgx: Move to selftests/sgx
Date: Mon, 30 Mar 2020 07:51:01 -0700	[thread overview]
Message-ID: <20200330145101.GB24988@linux.intel.com> (raw)
In-Reply-To: <20200320174716.27944-2-jarkko.sakkinen@linux.intel.com>

On Fri, Mar 20, 2020 at 07:47:16PM +0200, Jarkko Sakkinen wrote:
> Move selftest under the top level selftests directory so that we don't
> need to clutter x86/Makefile. The changes made for x86/Makefile caused
> also issues with packaging the selftests. Finally, SGX assets need their
> own tailored compilation environment.
> 
> With this change BuildRoot nicely packages both standard x86 selftests
> and our SGX test.
> 
> Cc: Sean Christopherson <sean.j.christopherson@intel.com>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> ---
>  tools/testing/selftests/Makefile                     |  1 +
>  tools/testing/selftests/{x86 => }/sgx/.gitignore     |  0
>  tools/testing/selftests/{x86 => }/sgx/Makefile       | 12 +++++++++---
>  tools/testing/selftests/{x86 => }/sgx/call.S         |  0
>  tools/testing/selftests/{x86 => }/sgx/defines.h      |  4 ++--
>  tools/testing/selftests/{x86 => }/sgx/encl.c         |  0
>  tools/testing/selftests/{x86 => }/sgx/encl.lds       |  0
>  .../testing/selftests/{x86 => }/sgx/encl_bootstrap.S |  0
>  tools/testing/selftests/{x86 => }/sgx/main.c         |  0
>  tools/testing/selftests/{x86 => }/sgx/main.h         |  0
>  tools/testing/selftests/{x86 => }/sgx/sign.c         |  0
>  11 files changed, 12 insertions(+), 5 deletions(-)
>  rename tools/testing/selftests/{x86 => }/sgx/.gitignore (100%)
>  rename tools/testing/selftests/{x86 => }/sgx/Makefile (83%)
>  rename tools/testing/selftests/{x86 => }/sgx/call.S (100%)
>  rename tools/testing/selftests/{x86 => }/sgx/defines.h (71%)
>  rename tools/testing/selftests/{x86 => }/sgx/encl.c (100%)
>  rename tools/testing/selftests/{x86 => }/sgx/encl.lds (100%)
>  rename tools/testing/selftests/{x86 => }/sgx/encl_bootstrap.S (100%)
>  rename tools/testing/selftests/{x86 => }/sgx/main.c (100%)
>  rename tools/testing/selftests/{x86 => }/sgx/main.h (100%)
>  rename tools/testing/selftests/{x86 => }/sgx/sign.c (100%)
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 6ec503912bea..183a050b5bda 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -63,6 +63,7 @@ TARGETS += user
>  TARGETS += vm
>  TARGETS += x86
>  TARGETS += zram
> +TARGETS += sgx

The scope of the subject for the selftest patch probably should be changed
to drop the "x86" part, e.g.

  selftests/sgx: Add a selftest for SGX

or
  selftests: Add a selftest for SGX

instead of

  selftests/x86: Add a selftest for SGX

  parent reply	other threads:[~2020-03-30 14:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 17:47 [PATCH 1/2] Revert "selftests/x86: Recurse into subdirectories" Jarkko Sakkinen
2020-03-20 17:47 ` [PATCH 2/2] selftests/x86/sgx: Move to selftests/sgx Jarkko Sakkinen
2020-03-20 17:52   ` Jarkko Sakkinen
2020-03-20 18:09     ` Jarkko Sakkinen
2020-03-20 18:10       ` Jarkko Sakkinen
2020-03-30 14:51   ` Sean Christopherson [this message]
2020-03-30 19:19     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200330145101.GB24988@linux.intel.com \
    --to=sean.j.christopherson@intel.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=linux-sgx@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).