From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Sean Christopherson <sean.j.christopherson@intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-sgx@vger.kernel.org, akpm@linux-foundation.org,
dave.hansen@intel.com, nhorman@redhat.com, npmccallum@redhat.com,
haitao.huang@intel.com, andriy.shevchenko@linux.intel.com,
tglx@linutronix.de, kai.svahn@intel.com, josh@joshtriplett.org,
luto@kernel.org, kai.huang@intel.com, rientjes@google.com,
cedric.xing@intel.com, puiterwijk@redhat.com,
Jethro Beekman <jethro@fortanix.com>
Subject: Re: [PATCH v30 08/20] x86/sgx: Add functions to allocate and free EPC pages
Date: Thu, 28 May 2020 22:07:18 +0300 [thread overview]
Message-ID: <20200528190718.GA2147934@linux.intel.com> (raw)
In-Reply-To: <20200528171635.GB382@zn.tnic>
On Thu, May 28, 2020 at 07:16:35PM +0200, Borislav Petkov wrote:
> Lemme reply to all mails with one. :-)
>
> I think Sean almost had it:
>
> > sgx_alloc_epc_section -> sgx_map_epc_section
> > sgx_free_epc_section -> sgx_unmap_epc_section
>
> Or even
>
> sgx_setup_epc_section()
> sgx_free_epc_section()
I like these. Lets lock in.
> And except those last two. Those are allocating a page from the EPC
> sections so I'd call them:
>
> sgx_try_alloc_page -> sgx_alloc_epc_page_section
> __sgx_try_alloc_page -> __sgx_alloc_epc_page_section
>
> former doing the loop, latter doing the per-section list games.
sgx_alloc_epc_page_section() is a bit nasty and long name to use for
grabbing a page. And even the documentation spoke about grabbing before
this naming discussion. I think it is a great description what is going
on. Everytime I talk about the subject I talk about grabbing.
Lets just say that your suggestion, I could not use in a conference
talk as a verb when I describe what is going on. That function
signature does not fit to my mouth :-) I would talk about
grabbing a page.
This how I refactored yesterday (is in my GIT tree already):
/**
* sgx_grab_page() - Grab a free EPC page
* @owner: the owner of the EPC page
* @reclaim: reclaim pages if necessary
*
* Iterate through EPC sections and borrow a free EPC page to the caller. When a
* page is no longer needed it must be released with sgx_free_page(). If
* @reclaim is set to true, directly reclaim pages when we are out of pages. No
* mm's can be locked when @reclaim is set to true.
*
* Finally, wake up ksgxswapd when the number of pages goes below the watermark
* before returning back to the caller.
*
* Return:
* an EPC page,
* -errno on error
*/
I also rewrote the kdoc.
I do agree that sgx_try_grab_page() should be renamed as __sgx_grab_page().
/Jarkko
next prev parent reply other threads:[~2020-05-28 19:07 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 0:43 [PATCH v30 00/20] Intel SGX foundations Jarkko Sakkinen
2020-05-15 0:43 ` [PATCH v30 01/20] x86/cpufeatures: x86/msr: Add Intel SGX hardware bits Jarkko Sakkinen
2020-05-20 12:16 ` Borislav Petkov
2020-05-20 14:00 ` Jarkko Sakkinen
2020-05-15 0:43 ` [PATCH v30 02/20] x86/cpufeatures: x86/msr: Intel SGX Launch Control " Jarkko Sakkinen
2020-05-20 12:23 ` Borislav Petkov
2020-05-20 14:04 ` Jarkko Sakkinen
2020-05-15 0:43 ` [PATCH v30 03/20] x86/mm: x86/sgx: Signal SIGSEGV with PF_SGX Jarkko Sakkinen
2020-05-15 0:43 ` [PATCH v30 04/20] x86/sgx: Add SGX microarchitectural data structures Jarkko Sakkinen
2020-05-20 18:47 ` Borislav Petkov
2020-05-20 21:04 ` Sean Christopherson
2020-05-22 15:54 ` Jarkko Sakkinen
2020-05-22 16:13 ` Sean Christopherson
2020-05-22 19:50 ` Jarkko Sakkinen
2020-05-25 8:20 ` Borislav Petkov
2020-05-27 19:43 ` Jarkko Sakkinen
2020-05-15 0:43 ` [PATCH v30 05/20] x86/sgx: Add wrappers for ENCLS leaf functions Jarkko Sakkinen
2020-05-15 0:43 ` [PATCH v30 06/20] x86/cpu/intel: Detect SGX support Jarkko Sakkinen
2020-05-15 0:43 ` [PATCH v30 07/20] x86/sgx: Enumerate and track EPC sections Jarkko Sakkinen
2020-05-25 9:23 ` Borislav Petkov
2020-05-27 3:56 ` Sean Christopherson
2020-05-27 20:35 ` Borislav Petkov
2020-05-28 7:36 ` Jarkko Sakkinen
2020-05-28 5:25 ` Jarkko Sakkinen
2020-05-28 5:35 ` Jarkko Sakkinen
2020-05-28 6:14 ` Jarkko Sakkinen
2020-05-28 6:16 ` Jarkko Sakkinen
2020-05-28 5:13 ` Jarkko Sakkinen
2020-05-15 0:43 ` [PATCH v30 08/20] x86/sgx: Add functions to allocate and free EPC pages Jarkko Sakkinen
2020-05-26 12:52 ` Borislav Petkov
2020-05-27 4:21 ` Sean Christopherson
2020-05-27 20:46 ` Borislav Petkov
2020-05-28 0:52 ` Sean Christopherson
2020-05-28 6:51 ` Jarkko Sakkinen
2020-05-28 1:23 ` Jarkko Sakkinen
2020-05-28 1:36 ` Sean Christopherson
2020-05-28 6:52 ` Jarkko Sakkinen
2020-05-28 17:16 ` Borislav Petkov
2020-05-28 17:19 ` Sean Christopherson
2020-05-28 17:27 ` Borislav Petkov
2020-05-28 17:34 ` Sean Christopherson
2020-05-28 19:07 ` Jarkko Sakkinen [this message]
2020-05-28 19:59 ` Sean Christopherson
2020-05-29 3:28 ` Jarkko Sakkinen
2020-05-29 3:37 ` Sean Christopherson
2020-05-29 5:07 ` Jarkko Sakkinen
2020-05-29 8:12 ` Jarkko Sakkinen
2020-05-29 8:13 ` Jarkko Sakkinen
2020-05-29 3:38 ` Jarkko Sakkinen
2020-05-15 0:43 ` [PATCH v30 09/20] mm: Introduce vm_ops->may_mprotect() Jarkko Sakkinen
2020-05-29 12:10 ` Borislav Petkov
2020-05-29 18:18 ` Jarkko Sakkinen
2020-05-29 18:28 ` Dave Hansen
2020-05-31 23:12 ` Jarkko Sakkinen
2020-05-15 0:44 ` [PATCH v30 10/20] x86/sgx: Linux Enclave Driver Jarkko Sakkinen
2020-05-21 19:12 ` Sean Christopherson
2020-05-22 19:26 ` Jarkko Sakkinen
2020-05-22 19:39 ` Jarkko Sakkinen
2020-05-22 3:33 ` Sean Christopherson
2020-05-15 0:44 ` [PATCH v30 11/20] x86/sgx: Add provisioning Jarkko Sakkinen
2020-05-15 0:44 ` [PATCH v30 12/20] x86/sgx: Add a page reclaimer Jarkko Sakkinen
2020-05-22 6:58 ` Sean Christopherson
2020-05-22 19:57 ` Jarkko Sakkinen
2020-05-22 21:52 ` Sean Christopherson
2020-05-22 7:15 ` Sean Christopherson
2020-05-22 19:47 ` Jarkko Sakkinen
2020-05-15 0:44 ` [PATCH v30 13/20] x86/sgx: ptrace() support for the SGX driver Jarkko Sakkinen
2020-05-15 0:44 ` [PATCH v30 14/20] x86/vdso: Add support for exception fixup in vDSO functions Jarkko Sakkinen
2020-05-15 0:44 ` [PATCH v30 15/20] x86/fault: Add helper function to sanitize error code Jarkko Sakkinen
2020-05-15 0:44 ` [PATCH v30 16/20] x86/traps: Attempt to fixup exceptions in vDSO before signaling Jarkko Sakkinen
2020-05-15 0:44 ` [PATCH v30 17/20] x86/vdso: Implement a vDSO for Intel SGX enclave call Jarkko Sakkinen
2020-05-15 0:44 ` [PATCH v30 18/20] selftests/x86: Add a selftest for SGX Jarkko Sakkinen
2020-05-15 0:44 ` [PATCH v30 19/20] docs: x86/sgx: Document SGX micro architecture and kernel internals Jarkko Sakkinen
2020-05-15 0:44 ` [PATCH v30 20/20] x86/sgx: Update MAINTAINERS Jarkko Sakkinen
2020-05-16 8:57 ` [PATCH] x86/cpu/intel: Add nosgx kernel parameter Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528190718.GA2147934@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=cedric.xing@intel.com \
--cc=dave.hansen@intel.com \
--cc=haitao.huang@intel.com \
--cc=jethro@fortanix.com \
--cc=josh@joshtriplett.org \
--cc=kai.huang@intel.com \
--cc=kai.svahn@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=nhorman@redhat.com \
--cc=npmccallum@redhat.com \
--cc=puiterwijk@redhat.com \
--cc=rientjes@google.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).