From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9E96C433E0 for ; Tue, 7 Jul 2020 03:24:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACCDE206E6 for ; Tue, 7 Jul 2020 03:24:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Bd4qnYg/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727077AbgGGDYN (ORCPT ); Mon, 6 Jul 2020 23:24:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727044AbgGGDYN (ORCPT ); Mon, 6 Jul 2020 23:24:13 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28173C061755; Mon, 6 Jul 2020 20:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RgzAwteswgw6hXoFv25GanDvGPsGe03cSLNymorjRy8=; b=Bd4qnYg/NPpFrFGwxn0qKkp07Z Gz0BaywDD5NR3b+3zNdkdV3/vSPIHxB/KOe4Vom69jsxRrkZMvarfnavGoOEfrJJWA716RTP1Z0nb Sg+TxpWx7LjGYhGWXVu4Afd5x1jdkGDN4mQKoCenQmx2Vuk+hxglppQyOkfgv5txP1aFxT98w6SmO iXcmfRd6NBpH2kTFn51TaShlm/zpMOGC+AL5AkO5zb2mCVOBajzZqryj6e0C0J/v+AMck85YjJWkQ fq0/v02A/tyiIMO0/ea7AxDooISnwsMlgrgfBEFgQp9OkUAIptVwiMGjJdpQb7aJhJRpFDalGoS7y Ow+2ek1w==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jseDI-0003Ny-Ca; Tue, 07 Jul 2020 03:24:08 +0000 Date: Tue, 7 Jul 2020 04:24:08 +0100 From: Matthew Wilcox To: Sean Christopherson Cc: Jarkko Sakkinen , x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Jethro Beekman , andriy.shevchenko@linux.intel.com, asapek@google.com, bp@alien8.de, cedric.xing@intel.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, dave.hansen@intel.com, haitao.huang@intel.com, josh@joshtriplett.org, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, npmccallum@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com Subject: Re: [PATCH v34 10/24] mm: Add vm_ops->mprotect() Message-ID: <20200707032408.GE25523@casper.infradead.org> References: <20200707030204.126021-1-jarkko.sakkinen@linux.intel.com> <20200707030204.126021-11-jarkko.sakkinen@linux.intel.com> <20200707031424.GD25523@casper.infradead.org> <20200707032254.GB5208@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200707032254.GB5208@linux.intel.com> Sender: linux-sgx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Mon, Jul 06, 2020 at 08:22:54PM -0700, Sean Christopherson wrote: > On Tue, Jul 07, 2020 at 04:14:24AM +0100, Matthew Wilcox wrote: > > > + if (vma->vm_ops && vma->vm_ops->mprotect) { > > > + error = vma->vm_ops->mprotect(vma, nstart, tmp, prot); > > > + if (error) > > > + goto out; > > > + } > > Based on "... and then the vma owner can do whatever it needs to before > calling mprotect_fixup(), which is already not static", my interpretation > is that Matthew's intent was to do: > > if (vma->vm_ops && vma->vm_ops->mprotect) > error = = vma->vm_ops->mprotect(vma, nstart, tmp, prot); > else > error = mprotect_fixup(vma, &prev, nstart, tmp, newflags); > if (error) > goto out; > > i.e. make .mprotect() a full replacement as opposed to a prereq hook. Yes, it was. I was just looking at the next patch to be sure this was how I'd been misunderstood.