From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A3CC43333 for ; Tue, 12 Jan 2021 00:27:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5EDC22D58 for ; Tue, 12 Jan 2021 00:27:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403981AbhALA0E (ORCPT ); Mon, 11 Jan 2021 19:26:04 -0500 Received: from mga09.intel.com ([134.134.136.24]:25703 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404258AbhALARk (ORCPT ); Mon, 11 Jan 2021 19:17:40 -0500 IronPort-SDR: d4eeKbSErggpqqX/dyteihgQy7nSPXN5fGB6puobsrpDX2+u3cXz4YBPqR1+4f0RVkDRMNzX1Z YWwew6NwpP9A== X-IronPort-AV: E=McAfee;i="6000,8403,9861"; a="178108225" X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="178108225" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 16:16:59 -0800 IronPort-SDR: V/rdT/NpX14Em9VdfUh0lvAbfZYGr4tsWdhdV4aVd2g6hdhEYRz1MXLhaVC9DZY9ACUPVA5v5P xPmscapQictw== X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="397194345" Received: from edelafu-mobl1.amr.corp.intel.com (HELO khuang2-desk.gar.corp.intel.com) ([10.252.142.150]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 16:16:55 -0800 Date: Tue, 12 Jan 2021 13:16:53 +1300 From: Kai Huang To: Jarkko Sakkinen Cc: linux-sgx@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org, seanjc@google.com, luto@kernel.org, dave.hansen@intel.com, haitao.huang@intel.com, pbonzini@redhat.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com Subject: Re: [RFC PATCH 02/23] x86/sgx: Add enum for SGX_CHILD_PRESENT error code Message-Id: <20210112131653.d8150b795dc64e0add0e809f@intel.com> In-Reply-To: References: <2a41e15dfda722dd1e34feeda34ce864cd82361b.1609890536.git.kai.huang@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Tue, 12 Jan 2021 01:32:19 +0200 Jarkko Sakkinen wrote: > On Wed, Jan 06, 2021 at 02:55:19PM +1300, Kai Huang wrote: > > From: Sean Christopherson > > > > SGX virtualization requires to allocate "raw" EPC and use it as "virtual > > EPC" for SGX guest. Unlike EPC used by SGX driver, virtual EPC doesn't > > track how EPC pages are used in VM, e.g. (de)construction of enclaves, > > so it cannot guarantee EREMOVE success, e.g. it doesn't have a priori > > knowledge of which pages are SECS with non-zero child counts. > > > > Add SGX_CHILD_PRESENT for use by SGX virtualization to assert EREMOVE > > failures are expected, but only due to SGX_CHILD_PRESENT. > > > > Signed-off-by: Sean Christopherson > > Signed-off-by: Kai Huang > > Acked-by: Jarkko Sakkinen Thanks Jarkko. Dave suggested to change patch subject to explicitly call out hardware error code: Add SGX_CHILD_PRESENT hardware error code I suppose this also works for you, and I can have your Acked-by after I changed that in v2? Thanks, -Kai