From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC53BC433DB for ; Wed, 24 Mar 2021 09:48:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 752E361A02 for ; Wed, 24 Mar 2021 09:48:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232579AbhCXJrf (ORCPT ); Wed, 24 Mar 2021 05:47:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232500AbhCXJr3 (ORCPT ); Wed, 24 Mar 2021 05:47:29 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F06BC061763; Wed, 24 Mar 2021 02:47:28 -0700 (PDT) Received: from zn.tnic (p200300ec2f0a0800e1aaf92fe048fc85.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:800:e1aa:f92f:e048:fc85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D07BD1EC03A0; Wed, 24 Mar 2021 10:47:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1616579241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=srWGc0OqLsvw93jos01M8hInTD8o7TJm1knv6fe7CgA=; b=p5BIIlGcz9jFUFUYmrFNzdIRY6HUPV25NcTLUUKsPZmJEf7Op1ZmzfXijK8nXdPMg+wmMu bWV4p7zUoaReiDred/SEgjBlQO4RS7qUfJS+l2pn2N3nwsNRu62iF35ji/EWZMGtEHVtBd OrqJqNeStTQWLXQn4jXVbI8usLxBWnA= Date: Wed, 24 Mar 2021 10:47:20 +0100 From: Borislav Petkov To: ira.weiny@intel.com Cc: Thomas Gleixner , Ingo Molnar , x86@kernel.org, Sean Christopherson , Jethro Beekman , Jarkko Sakkinen , Dave Hansen , Dave Hansen , linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] x86: Remove unnecessary kmap() from sgx_ioc_enclave_init() Message-ID: <20210324094720.GA5010@zn.tnic> References: <20210306002058.303796-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210306002058.303796-1-ira.weiny@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Fri, Mar 05, 2021 at 04:20:58PM -0800, ira.weiny@intel.com wrote: > Subject: Re: [PATCH v5] x86: Remove unnecessary kmap() from sgx_ioc_enclave_init() The tip tree preferred format for patch subject prefixes is 'subsys/component:', e.g. 'x86/apic:', 'x86/mm/fault:', 'sched/fair:', 'genirq/core:'. Please do not use file names or complete file paths as prefix. 'git log path/to/file' should give you a reasonable hint in most cases. > From: Ira Weiny > > kmap is inefficient and we are trying to reduce the usage in the kernel. Please use passive voice in your commit message: no "we" or "I", etc, and describe your changes in imperative mood. Also, pls read section "2) Describe your changes" in Documentation/process/submitting-patches.rst for more details. Bottom line is: personal pronouns are ambiguous in text, especially with so many parties/companies/etc developing the kernel so let's avoid them please. > @@ -615,11 +614,14 @@ static long sgx_ioc_enclave_init(struct sgx_encl *encl, void __user *arg) > if (copy_from_user(&init_arg, arg, sizeof(init_arg))) > return -EFAULT; > > - initp_page = alloc_page(GFP_KERNEL); > - if (!initp_page) > + /* > + * sigstruct must be on a page boundry and token on a 512 byte boundry > + * kmalloc() gives us this alignment when allocating PAGE_SIZE bytes Please integrate scripts/checkpatch.pl into your patch creation workflow. Some of the warnings/errors *actually* make sense. WARNING: 'boundry' may be misspelled - perhaps 'boundary'? #90: FILE: arch/x86/kernel/cpu/sgx/ioctl.c:618: + * sigstruct must be on a page boundry and token on a 512 byte boundry ^^^^^^^ WARNING: 'boundry' may be misspelled - perhaps 'boundary'? #90: FILE: arch/x86/kernel/cpu/sgx/ioctl.c:618: + * sigstruct must be on a page boundry and token on a 512 byte boundry ^^^^^^^ Also, do you see how other comments in this file are proper sentences? Please formulate yours this way too. The change itself looks ok. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette