From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31578C433DB for ; Mon, 1 Feb 2021 12:56:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC78B64EAC for ; Mon, 1 Feb 2021 12:56:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230016AbhBAM4s (ORCPT ); Mon, 1 Feb 2021 07:56:48 -0500 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:42581 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231584AbhBAM4o (ORCPT ); Mon, 1 Feb 2021 07:56:44 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R941e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=tianjia.zhang@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0UNa.ooL_1612184152; Received: from B-455UMD6M-2027.local(mailfrom:tianjia.zhang@linux.alibaba.com fp:SMTPD_---0UNa.ooL_1612184152) by smtp.aliyun-inc.com(127.0.0.1); Mon, 01 Feb 2021 20:55:53 +0800 Subject: Re: [PATCH v3 4/5] x86/sgx: Allows ioctl PROVISION to execute before CREATE To: Jarkko Sakkinen Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Sean Christopherson , Shuah Khan , x86@kernel.org, linux-sgx@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jia Zhang References: <20210124062907.88229-1-tianjia.zhang@linux.alibaba.com> <20210124062907.88229-5-tianjia.zhang@linux.alibaba.com> From: Tianjia Zhang Message-ID: <478a3f95-c11e-ea37-2a80-c0976c7a189e@linux.alibaba.com> Date: Mon, 1 Feb 2021 20:55:51 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On 1/30/21 9:26 PM, Jarkko Sakkinen wrote: > On Sun, Jan 24, 2021 at 02:29:06PM +0800, Tianjia Zhang wrote: >> In the function sgx_create_enclave(), the direct assignment >> operation of attributes_mask determines that the ioctl PROVISION >> operation must be executed after the ioctl CREATE operation, >> which will limit the flexibility of sgx developers. >> >> This patch takes the assignment of `attributes_mask` from the >> function sgx_create_enclave() has been moved to the function >> sgx_open() to avoid this restriction. >> >> Signed-off-by: Tianjia Zhang > > The commit message should explicit that the API behaviour changes > as the result. Please don't use hyphens in quoting. > > /Jarkko > Will be improved in the next version. Best regards, Tianjia >> --- >> arch/x86/kernel/cpu/sgx/driver.c | 1 + >> arch/x86/kernel/cpu/sgx/ioctl.c | 1 - >> 2 files changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/kernel/cpu/sgx/driver.c b/arch/x86/kernel/cpu/sgx/driver.c >> index f2eac41bb4ff..fba0d0bfe976 100644 >> --- a/arch/x86/kernel/cpu/sgx/driver.c >> +++ b/arch/x86/kernel/cpu/sgx/driver.c >> @@ -36,6 +36,7 @@ static int sgx_open(struct inode *inode, struct file *file) >> return ret; >> } >> >> + encl->attributes_mask = SGX_ATTR_DEBUG | SGX_ATTR_MODE64BIT | SGX_ATTR_KSS; >> file->private_data = encl; >> >> return 0; >> diff --git a/arch/x86/kernel/cpu/sgx/ioctl.c b/arch/x86/kernel/cpu/sgx/ioctl.c >> index 90a5caf76939..1c6ecf9fbeff 100644 >> --- a/arch/x86/kernel/cpu/sgx/ioctl.c >> +++ b/arch/x86/kernel/cpu/sgx/ioctl.c >> @@ -109,7 +109,6 @@ static int sgx_encl_create(struct sgx_encl *encl, struct sgx_secs *secs) >> encl->base = secs->base; >> encl->size = secs->size; >> encl->attributes = secs->attributes; >> - encl->attributes_mask = SGX_ATTR_DEBUG | SGX_ATTR_MODE64BIT | SGX_ATTR_KSS; >> >> /* Set only after completion, as encl->lock has not been taken. */ >> set_bit(SGX_ENCL_CREATED, &encl->flags); >> -- >> 2.19.1.3.ge56e4f7 >> >>