From: Dave Hansen <dave.hansen@intel.com>
To: Jarkko Sakkinen <jarkko@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: linux-sgx@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
reinette.chatre@intel.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso'
Date: Tue, 11 May 2021 11:49:18 -0700 [thread overview]
Message-ID: <4b8d9604-8d35-eefe-41cb-511b92a3f086@intel.com> (raw)
In-Reply-To: <20210508035648.18176-1-jarkko@kernel.org>
On 5/7/21 8:56 PM, Jarkko Sakkinen wrote:
> Rename symbols for better clarity:
>
> * 'eenter' -> 'vdso_sgx_enter_enclave'
> * 'sgx_call_vdso' -> 'sgx_enter_enclave'
Another sentence or two here would do wonders:
'eenter' might be confused for directly calling ENCLU[EENTER]. It does
not. It calls into the VDSO, which actually has the EENTER instruction.
'sgx_call_vdso' is *only* used for entering the enclave. It's not some
generic SGX call into the VDSO.
Make the naming reflect that.
Right?
next prev parent reply other threads:[~2021-05-11 18:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 3:56 [PATCH v4 1/2] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso' Jarkko Sakkinen
2021-05-08 3:56 ` [PATCH v4 2/2] selftests/sgx: Migrate to kselftest harness Jarkko Sakkinen
2021-05-11 18:42 ` Reinette Chatre
2021-05-12 1:10 ` Jarkko Sakkinen
2021-05-12 15:56 ` Reinette Chatre
2021-05-12 19:17 ` Jarkko Sakkinen
2021-05-11 18:49 ` Dave Hansen [this message]
2021-05-12 1:14 ` [PATCH v4 1/2] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso' Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b8d9604-8d35-eefe-41cb-511b92a3f086@intel.com \
--to=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).