From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5631DC4332E for ; Thu, 4 Mar 2021 00:49:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DDDE64F11 for ; Thu, 4 Mar 2021 00:49:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240164AbhCDAtS (ORCPT ); Wed, 3 Mar 2021 19:49:18 -0500 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:39385 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239577AbhCCMFO (ORCPT ); Wed, 3 Mar 2021 07:05:14 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=tianjia.zhang@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0UQFn22N_1614772990; Received: from B-455UMD6M-2027.local(mailfrom:tianjia.zhang@linux.alibaba.com fp:SMTPD_---0UQFn22N_1614772990) by smtp.aliyun-inc.com(127.0.0.1); Wed, 03 Mar 2021 20:03:11 +0800 Subject: Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE To: Andy Lutomirski Cc: Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Sean Christopherson , Shuah Khan , X86 ML , linux-sgx@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , LKML , Jia Zhang References: <20210301051836.30738-1-tianjia.zhang@linux.alibaba.com> <3bcdcf04-4bed-ed95-84b6-790675f18240@linux.alibaba.com> From: Tianjia Zhang Message-ID: <870e9a2e-65dd-131d-78c2-24de1ffffd31@linux.alibaba.com> Date: Wed, 3 Mar 2021 20:03:10 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On 3/2/21 1:54 PM, Andy Lutomirski wrote: > On Mon, Mar 1, 2021 at 9:06 PM Tianjia Zhang > wrote: >> >> >> >> On 3/1/21 5:54 PM, Jarkko Sakkinen wrote: >>> On Mon, Mar 01, 2021 at 01:18:36PM +0800, Tianjia Zhang wrote: >>>> q2 is not always 384-byte length. Sometimes it only has 383-byte. >>> >>> What does determine this? >>> >>>> In this case, the valid portion of q2 is reordered reversely for >>>> little endian order, and the remaining portion is filled with zero. >>> >>> I'm presuming that you want to say "In this case, q2 needs to be reversed because...". >>> >>> I'm lacking these details: >>> >>> 1. Why the length of Q2 can vary? >>> 2. Why reversing the bytes is the correct measure to counter-measure >>> this variation? >>> >>> /Jarkko >>> >> >> When use openssl to generate a key instead of using the built-in >> sign_key.pem, there is a probability that will encounter this problem. >> >> Here is a problematic key I encountered. The calculated q1 and q2 of >> this key are both 383 bytes, If the length is not processed, the >> hardware signature will fail. > > Presumably the issue is that some keys have parameters that have > enough leading 0 bits to be effectively shorter. The openssl API > (and, sadly, a bunch of the ASN.1 stuff) treats these parameters as > variable-size integers. > I agree with your opinion. Thanks, Tianjia