From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66FEFC2D0A8 for ; Tue, 29 Sep 2020 01:37:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C21321734 for ; Tue, 29 Sep 2020 01:37:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=amacapital-net.20150623.gappssmtp.com header.i=@amacapital-net.20150623.gappssmtp.com header.b="WJ1q7OFP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727378AbgI2Bh6 (ORCPT ); Mon, 28 Sep 2020 21:37:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727238AbgI2Bh6 (ORCPT ); Mon, 28 Sep 2020 21:37:58 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80D81C0613CE for ; Mon, 28 Sep 2020 18:37:58 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id d9so2951487pfd.3 for ; Mon, 28 Sep 2020 18:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amacapital-net.20150623.gappssmtp.com; s=20150623; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=5NPObd62S6aBUFhQDjWfIQs23I/Y2IDiU6H1RNmK13s=; b=WJ1q7OFPBQmaPBAuQv1cuQ1jqGuJUbyiza+3H3+5zHx34lFbUrydjc70ppNBxmY5ZU 1KWPSFDT0UEAEURObrsKVN8A2K5ouY8hMdEQKHZBDc2bwNBmSUAruDRqXPpEgeJANYXQ okHjxUheB+c8HzhvQyVhEcbRccfh+CrvsEg2HZlYfLqaku2S1zFfaDypxp/f38jrKYaW Ug31t+mfiuaWVhaYYqlExyiZFffjJQ31w5dbdVtt6ZUNTqN4UNVGx9u/wTVA7RfZUI+Q oqOVutNXs8c0JXlKcwiS8dlClx2nSAyAWPS75do9EmENmM7EOzaMXVYd+WUr1zdH8Tgr m2XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=5NPObd62S6aBUFhQDjWfIQs23I/Y2IDiU6H1RNmK13s=; b=N2rz08onh1djxc0swHJnuZXHVpChiqdtJ/IYO+XibSdSc+bI7MKTkSSHBchvdHNekI 4mhV1fqnZJ4PSXsKuZILdeEFe6alZR+xdmIv9n62KNS5n+O89CL0rTuEjka05afPzBuq ZCZ7+Z1n1lRUyiheZ2uHx5WwFHiTf8r/I2+fKaSkOu4gE3kXQ8dNZFaBeDNfYPGdXkwr fB1BJ06/sKrTjmR1/5TBP7qM2bj6VWSjb706W2yZK9l8HzvuDQ8mSw3aR2qkLTIQmN4J wFK6Zj8q3HOmr/HH7pjSofK5+npWKdksT/6dL3DImsFUH2ich9f0eroj0ug1DKXxmX13 w+mA== X-Gm-Message-State: AOAM530cyDoHWESZZAQrhm/r3aJAUbzJ82HqHZmZv6CFyLt1MrkFnzBP KojXahZM1/EQNhQCoXnSElKo0g== X-Google-Smtp-Source: ABdhPJyk1bXdJLUhnY4m021GAUsK4cpkqpHatCZw4JcZmn3VvGTxOHf0m0r7lBHR4ZLMLZpkATlk6g== X-Received: by 2002:a63:4854:: with SMTP id x20mr1452634pgk.220.1601343477985; Mon, 28 Sep 2020 18:37:57 -0700 (PDT) Received: from ?IPv6:2601:646:c200:1ef2:1921:87c6:634:c91c? ([2601:646:c200:1ef2:1921:87c6:634:c91c]) by smtp.gmail.com with ESMTPSA id s2sm2394079pjg.52.2020.09.28.18.37.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Sep 2020 18:37:56 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Andy Lutomirski Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v38 10/24] mm: Add vm_ops->mprotect() Date: Mon, 28 Sep 2020 18:37:54 -0700 Message-Id: References: <20200928201959.GA3856@linux.intel.com> Cc: Dave Hansen , Sean Christopherson , Haitao Huang , Andy Lutomirski , X86 ML , linux-sgx@vger.kernel.org, LKML , Linux-MM , Andrew Morton , Matthew Wilcox , Jethro Beekman , Darren Kenny , Andy Shevchenko , asapek@google.com, Borislav Petkov , "Xing, Cedric" , chenalexchen@google.com, Conrad Parker , cyhanish@google.com, "Huang, Haitao" , Josh Triplett , "Huang, Kai" , "Svahn, Kai" , Keith Moyer , Christian Ludloff , Neil Horman , Nathaniel McCallum , Patrick Uiterwijk , David Rientjes , Thomas Gleixner , yaozhangx@google.com In-Reply-To: <20200928201959.GA3856@linux.intel.com> To: Jarkko Sakkinen X-Mailer: iPhone Mail (18A393) Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org > On Sep 28, 2020, at 1:20 PM, Jarkko Sakkinen wrote: >=20 > =EF=BB=BFOn Mon, Sep 28, 2020 at 12:45:27PM -0700, Dave Hansen wrote: >>> On 9/28/20 12:32 PM, Jarkko Sakkinen wrote: >>> My problem is that I fully agree what you say in your description but >>> disagree on that EMODPE should not be mentioned. >>=20 >> I'll just be very clear: I'm not willing to ack any patch with a >> changelog that has more than a passing mention of EMODPE. >>=20 >> Do what you think is best, but if sticking to your guns may deplete the >> pool of folks willing to ack your patch. >=20 > I do see it mentioned in other responses too in this thread, and not > just mine. >=20 > And here is even a request to get it to the changelog: >=20 > https://lore.kernel.org/linux-sgx/1B23E216-0229-4BDD-8B09-807256A54AF5@ama= capital.net/ >=20 > I'm absolutely fine not to mention EMODPE but after re-reading the > thread, it is not like there is one voice on it. I don't really > care all that much whether it is mentioned or not but there should > be some reasonable logic behind the decision. I don=E2=80=99t personally care that much about EMODPE but, you could probab= ly get the point across with something like: SGX=E2=80=99s EPCM permission bits do not obviate the need to enforce these r= ules in the PTEs because enclaves can freely modify the EPCM permissions usi= ng EMODPE. IOW, EMODPE is not really special here; rather, EMODPE=E2=80=99s existence d= emonstrates that EADD / EEXTEND are not special.