From: Jarkko Sakkinen <jarkko@kernel.org>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Sean Christopherson <seanjc@google.com>,
Shuah Khan <shuah@kernel.org>,
x86@kernel.org, linux-sgx@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Jia Zhang <zhang.jia@linux.alibaba.com>
Subject: Re: [PATCH v4 3/5] x86/sgx: Optimize the free_cnt count in sgx_epc_section
Date: Tue, 2 Feb 2021 23:54:08 +0200 [thread overview]
Message-ID: <YBnKAP2fIGs7F5Xm@kernel.org> (raw)
In-Reply-To: <20210201132653.35690-4-tianjia.zhang@linux.alibaba.com>
On Mon, Feb 01, 2021 at 09:26:51PM +0800, Tianjia Zhang wrote:
> 'section->free_cnt' represents the free page in sgx_epc_section,
> which is assigned once after initialization. In fact, just after the
> initialization is completed, the pages are in the init_laundry_list
> list and cannot be allocated. This needs to be recovered by EREMOVE
> of function sgx_sanitize_section() before it can be used as a page
> that can be allocated. The sgx_sanitize_section() will be called in
> the kernel thread ksgxd.
>
> This patch moves the initialization of 'section->free_cnt' from the
> initialization function sgx_setup_epc_section() to the function
> sgx_sanitize_section(), and then accumulates the count after the
> successful execution of EREMOVE. This seems to be more reasonable,
> free_cnt will also truly reflect the allocatable free pages in EPC.
>
> Sined-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> Reviewed-by: Sean Christopherson <seanjc@google.com>
I just copy-paste my earlier response to save time sice you seem
to save time by ignoring it and spamming with the same obviously
illegit patch.
https://lore.kernel.org/linux-sgx/YBGlodsOaX4cWAtl@kernel.org/
/Jarkko
next prev parent reply other threads:[~2021-02-02 21:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 13:26 [PATCH v4 0/5] Some optimizations related to sgx Tianjia Zhang
2021-02-01 13:26 ` [PATCH v4 1/5] selftests/x86: Use getauxval() to simplify the code in sgx Tianjia Zhang
2021-02-02 22:02 ` Jarkko Sakkinen
2021-02-09 0:09 ` Shuah Khan
2021-02-12 12:20 ` Jarkko Sakkinen
2021-02-01 13:26 ` [PATCH v4 2/5] x86/sgx: Reduce the locking range in sgx_sanitize_section() Tianjia Zhang
2021-02-02 22:00 ` Jarkko Sakkinen
2021-02-11 6:15 ` Tianjia Zhang
2021-02-01 13:26 ` [PATCH v4 3/5] x86/sgx: Optimize the free_cnt count in sgx_epc_section Tianjia Zhang
2021-02-02 21:54 ` Jarkko Sakkinen [this message]
2021-02-11 6:05 ` Tianjia Zhang
2021-02-01 13:26 ` [PATCH v4 4/5] x86/sgx: Allows ioctl PROVISION to execute before CREATE Tianjia Zhang
2021-02-02 21:57 ` Jarkko Sakkinen
2021-02-11 6:11 ` Tianjia Zhang
2021-02-01 13:26 ` [PATCH v4 5/5] x86/sgx: Remove redundant if conditions in sgx_encl_create Tianjia Zhang
2021-02-02 22:04 ` Jarkko Sakkinen
2021-02-11 6:17 ` Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBnKAP2fIGs7F5Xm@kernel.org \
--to=jarkko@kernel.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=x86@kernel.org \
--cc=zhang.jia@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).