From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: linux-sgx@vger.kernel.org, haitao.huang@intel.com,
dan.j.williams@intel.com, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/sgx: Add a basic NUMA allocation scheme to sgx_alloc_epc_page()
Date: Tue, 23 Feb 2021 21:33:49 +0200 [thread overview]
Message-ID: <YDVYnRdxHOME7cNe@kernel.org> (raw)
In-Reply-To: <1ce6670a-ea35-c1bd-b5df-c52cc44dc433@intel.com>
On Tue, Feb 23, 2021 at 11:20:55AM -0800, Dave Hansen wrote:
> On 2/23/21 11:17 AM, Jarkko Sakkinen wrote:
> > Instead, let's just:
> >
> > 1. Have a global sgx_free_epc_list and remove sgx_epc_section.
> > Pages from this are allocated from this in LIFO fashion.
> > 2. Instead add struct list_head node_list and use that for node
> > associated pages.
> > 3. Replace 'int section' with 'int node'.
>
> I was thinking of something similar.
>
> I'm fine with this approach.
Here's my two step plan.
1. Let's ack this with the cosmetic changes. It's good first baby
step to take.
2. I'll do another patch that wipes sgx_epc_section.
Both are functionally self-contained patch that improve. That's why
I don't see point in iterating them as a two patch patch set. One
patch at a time is less overhead.
/Jarkko
next prev parent reply other threads:[~2021-02-23 19:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 2:06 [PATCH] x86/sgx: Add a basic NUMA allocation scheme to sgx_alloc_epc_page() Jarkko Sakkinen
2021-02-22 0:54 ` Dave Hansen
2021-02-23 19:14 ` Dave Hansen
2021-02-24 17:29 ` Jarkko Sakkinen
2021-02-23 19:17 ` Jarkko Sakkinen
2021-02-23 19:20 ` Dave Hansen
2021-02-23 19:33 ` Jarkko Sakkinen [this message]
2021-02-23 21:42 ` Dave Hansen
2021-02-24 17:31 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDVYnRdxHOME7cNe@kernel.org \
--to=jarkko@kernel.org \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=haitao.huang@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).