From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: linux-sgx@vger.kernel.org, haitao.huang@intel.com,
dan.j.williams@intel.com, dave.hansen@linux.intel.com,
bp@alien8.de, tglx@linutronix.de, linux-kernel@vger.kernel.org,
x86@kernel.org
Subject: Re: [PATCH 0/3] Introduce version array structure: sgx_va
Date: Thu, 25 Feb 2021 03:01:54 +0200 [thread overview]
Message-ID: <YDb3Atu0ZbOpPZf5@kernel.org> (raw)
In-Reply-To: <64cac2aa-0c69-5438-1f0e-aa1386551198@intel.com>
On Wed, Feb 24, 2021 at 03:48:50PM -0800, Dave Hansen wrote:
> On 2/24/21 2:20 PM, Jarkko Sakkinen wrote:
> > The use of sgx_va can be later on extended to the following use cases:
> >
> > - A global VA for reclaimed SECS pages.
> > - A global VA for reclaimed VA pages.
> ...
> > arch/x86/kernel/cpu/sgx/driver.c | 3 +-
> > arch/x86/kernel/cpu/sgx/encl.c | 180 ++++++++++++++++++++++---------
> > arch/x86/kernel/cpu/sgx/encl.h | 36 ++++---
> > arch/x86/kernel/cpu/sgx/ioctl.c | 77 +++++--------
> > arch/x86/kernel/cpu/sgx/main.c | 19 +---
> > 5 files changed, 184 insertions(+), 131 deletions(-)
>
> It looks interesting.
>
> Were you planning on keeping this on the back burner until we need it
> more acutely? Or, were you thinking it should be merged immediately?
I think this can wait. Perhaps, this could be picked to some other patch
set, such as EDMM.
Let's just say that this should be part of anything that touches the page
reclaimer.
IDA might look odd. Mapping through IDA allocated ID's is for conserving
the amount of used EPC pages for the version array.
Alternative would be to linearly map enclave page offset to the VA page
index but that would introduce a sloppy allocation of EPC.
The selected approach, on the other hand, no matter how sparsely you create
enclave pages, that does not add to the amount of EPC VA page usage.
BTW, encl_page->va_page could be removed, and use sgx_va_get() to locate
the VA page, when needed. I'm open for opinions with this one: it's space
vs the cost of access question.
/Jarkko
next prev parent reply other threads:[~2021-02-25 1:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 22:20 [PATCH 0/3] Introduce version array structure: sgx_va Jarkko Sakkinen
2021-02-24 22:20 ` [PATCH 1/3] x86/sgx: Move struct sgx_va_page creation to sgx_alloc_va_page() Jarkko Sakkinen
2021-02-24 22:20 ` [PATCH 2/3] x86/sgx: Add a version array (VA) structure Jarkko Sakkinen
2021-02-24 22:20 ` [PATCH 3/3] x86/sgx: Use sgx_va for the enclave's version array Jarkko Sakkinen
2021-02-24 23:48 ` [PATCH 0/3] Introduce version array structure: sgx_va Dave Hansen
2021-02-25 1:01 ` Jarkko Sakkinen [this message]
2021-02-25 7:34 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDb3Atu0ZbOpPZf5@kernel.org \
--to=jarkko@kernel.org \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=haitao.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).