From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7A51ECAAD3 for ; Wed, 31 Aug 2022 18:44:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233111AbiHaSou (ORCPT ); Wed, 31 Aug 2022 14:44:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233033AbiHaSof (ORCPT ); Wed, 31 Aug 2022 14:44:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53B43BD5; Wed, 31 Aug 2022 11:44:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D994160E89; Wed, 31 Aug 2022 18:44:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8099C433D6; Wed, 31 Aug 2022 18:44:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661971473; bh=bXVzGMvvGTEaLDHMeK2hMUd2osC7vq1ST9RgLI8qV5U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YfRKBl2tseu5V+P2/pvJuHp+UPI5ey31PwfQxSywuqpZGSi40WnEajFVRczC8P4zN gXoHdizqUUk1IuSeLKKOVuoXEoRthT8H01oQVuH4xVglQI7HwDTHFzsYPTxXQjQMGi 1PTmzW4XFF/SBWsBrCRwuVo+MD5m2p8+2LMtVKtNg67gYmBDOID2KOyVaRNx0epJi0 ASEz6LAyypQBHuV7oPBehmEOu+KvuFSTaL4Miw428vBKGXp0x/uBpH63okNpvCFrpN b2+eMsGdVpCURl7biAfJIGMDRkhxdsoY+wBfIfyF/wbs6cm0jvbKxSs5PvMIHt3MA1 VfHplgSNet7ww== Date: Wed, 31 Aug 2022 21:44:28 +0300 From: "jarkko@kernel.org" To: Dave Hansen Cc: Haitao Huang , "Huang, Kai" , "pmenzel@molgen.mpg.de" , "linux-sgx@vger.kernel.org" , "x86@kernel.org" , "dave.hansen@linux.intel.com" , "Dhanraj, Vijay" , "Chatre, Reinette" , "mingo@redhat.com" , "tglx@linutronix.de" , "bp@alien8.de" , "hpa@zytor.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/6] x86/sgx: Do not consider unsanitized pages an error Message-ID: References: <1b3308a364317d36ad41961ea9cfee24aa122f02.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Wed, Aug 31, 2022 at 11:35:10AM -0700, Dave Hansen wrote: > Jarkko, Kai and Haitao, > > Can you three please start trimming your replies? You don't need to and > should not quote the entirety of your messages every time you reply. > > On 8/31/22 11:28, jarkko@kernel.org wrote: > >> Will it cause racing if we expose dev nodes to user space before > >> ksgxd is started and sensitization done? > > I'll to explain this. > > > > So the point is to fix the issue at hand, and fix it locally. > > > > Changing initialization order is simply out of context. It's > > not really an argument for or against changing it > > > > We are fixing sanitization here, and only that with zero > > side-effects to any other semantics. > > > > It's dictated by the development process [*] but more > > importantly it's also just plain common sense. > > Kai, I think your suggestion is reasonable. You make a good point about > not needing ksgxd for vepc. > > *But*, I think it's a bit too much for a bugfix that's headed to > -stable. I'm concerned that it will have unintended side effects, > *especially* when there's a working, tested alternative. Yeah, I also actually *do* agree that the suggestions could be reasonable. BR, Jarkko