From: Tejun Heo <tj@kernel.org>
To: Haitao Huang <haitao.huang@linux.intel.com>
Cc: jarkko@kernel.org, dave.hansen@linux.intel.com,
linux-kernel@vger.kernel.org, linux-sgx@vger.kernel.org,
cgroups@vger.kernel.org, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
vipinsh@google.com, kai.huang@intel.com,
reinette.chatre@intel.com, zhiquan1.li@intel.com,
kristen@linux.intel.com
Subject: Re: [PATCH 2/2] cgroup/misc: Change counters to be explicit 64bit types
Date: Tue, 18 Jul 2023 12:52:10 -1000 [thread overview]
Message-ID: <ZLcXmvDKheCRYOjG@slm.duckdns.org> (raw)
In-Reply-To: <20230718010845.35197-2-haitao.huang@linux.intel.com>
On Mon, Jul 17, 2023 at 06:08:45PM -0700, Haitao Huang wrote:
> So the variables can account for resources of huge quantities even on
> 32-bit machines.
>
> Signed-off-by: Haitao Huang <haitao.huang@linux.intel.com>
Applied to cgroup/for-6.6 with some whitespace adjustments. I think the code
is broken when we cross the signed boundary but that's not a new problem
caused by your patch. I think what we should do is to treat atomic64_t reads
as u64 instead of putting it in s64.
Thanks.
--
tejun
next prev parent reply other threads:[~2023-07-18 22:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 18:47 [PATCH] cgroup/misc: Fix an overflow Haitao Huang
2023-07-17 18:51 ` Tejun Heo
2023-07-17 18:55 ` Jarkko Sakkinen
2023-07-17 18:57 ` Tejun Heo
2023-07-17 19:01 ` Haitao Huang
2023-07-17 20:19 ` Haitao Huang
2023-07-17 20:37 ` Tejun Heo
2023-07-18 1:08 ` [PATCH 1/2] " Haitao Huang
2023-07-18 1:08 ` [PATCH 2/2] cgroup/misc: Change counters to be explicit 64bit types Haitao Huang
2023-07-18 22:52 ` Tejun Heo [this message]
2023-07-21 2:48 ` Haitao Huang
2023-07-21 12:02 ` [PATCH] cgroup/misc: Store atomic64_t reads to u64 Haitao Huang
2023-07-21 18:10 ` Tejun Heo
2023-07-18 1:11 ` [PATCH] cgroup/misc: Fix an overflow Haitao Huang
2023-07-18 15:41 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLcXmvDKheCRYOjG@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=haitao.huang@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=kristen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=reinette.chatre@intel.com \
--cc=vipinsh@google.com \
--cc=zhiquan1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).