From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>, linux-sgx@vger.kernel.org
Cc: Shuah Khan <shuah@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Jonathan Corbet <corbet@lwn.net>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Saravanan D <saravanand@fb.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Krish Sadhukhan <krish.sadhukhan@oracle.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] x86/sgx: Add SGX_MemTotal to /proc/meminfo
Date: Tue, 24 Aug 2021 04:16:11 +0300 [thread overview]
Message-ID: <e0522fa59b2029d6a2210c1113919b572746f794.camel@kernel.org> (raw)
In-Reply-To: <8e6e42b0-0a1e-6892-b601-ce4a94172ef1@intel.com>
On Mon, 2021-08-23 at 08:15 -0700, Dave Hansen wrote:
> On 8/18/21 6:25 AM, Jarkko Sakkinen wrote:
> > The amount of SGX memory on the system is determined by the BIOS and it
> > varies wildly between systems. It can be from dozens of MB's on desktops
> > or VM's, up to many GB's on servers. Just like for regular memory, it is
> > sometimes useful to know the amount of usable SGX memory in the system.
> >
> > Add SGX_MemTotal field to /proc/meminfo, which shows the total amount of
> > usable SGX memory in the system. E.g. with 32 MB reserved for SGX from
> > BIOS, the printout would be:
> >
> > SGX_MemTotal: 22528 kB
>
> The big question here: Do we want to put purely architecture-specific
> entries in (the currently quite arch-independent) /proc/meminfo?
>
> The current "DirectMap4k/2M/1G" entries from arch_report_meminfo() are
> arch-specific in their sizes, of course, but the concept is at least
> quite arch-independent.
I started with /proc/meminfo instead of /sys/devices/system/node/*/meminfo
because there is pre-existing arch callback, and secondary because it's also
better fit for my kselftest code.
The same discussion still applies to both files, they probably should follow a
matching pattern.
/Jarkko
prev parent reply other threads:[~2021-08-24 1:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 13:25 [PATCH] x86/sgx: Add SGX_MemTotal to /proc/meminfo Jarkko Sakkinen
2021-08-18 13:29 ` Jethro Beekman
2021-08-18 13:40 ` Jarkko Sakkinen
2021-08-18 18:34 ` Shuah Khan
2021-08-19 11:32 ` Jarkko Sakkinen
2021-08-23 15:15 ` Dave Hansen
2021-08-24 1:16 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0522fa59b2029d6a2210c1113919b572746f794.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=krish.sadhukhan@oracle.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=saravanand@fb.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).