From: Jarkko Sakkinen <jarkko@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>,
linux-sgx@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Jonathan Corbet <corbet@lwn.net>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 2/2] x86/sgx: Add SGX_MemTotal to /proc/meminfo
Date: Thu, 26 Aug 2021 19:17:40 +0300 [thread overview]
Message-ID: <e1ff36db0e7ed909653b6adb45094cc459dbad0b.camel@kernel.org> (raw)
In-Reply-To: <ba483b7e-19a3-d4d3-56c0-3371a77341cb@infradead.org>
On Wed, 2021-08-25 at 17:39 -0700, Randy Dunlap wrote:
> On 8/25/21 4:52 PM, Jarkko Sakkinen wrote:
> > The amount of SGX memory on the system is determined by the BIOS and it
> > varies wildly between systems. It can be from dozens of MB's on desktops
> > or VM's, up to many GB's on servers. Just like for regular memory, it is
> > sometimes useful to know the amount of usable SGX memory in the system.
> >
> > Add SGX_MemTotal field to /proc/meminfo, which shows the total amount of
> > usable SGX memory in the system. E.g. with 32 MB reserved for SGX from
> > BIOS, the printout would be:
> >
> > SGX_MemTotal: 22528 kB
> >
> > It is less than 32 MB because some of the space is reserved for Enclave
> > Page Cache Metadata (EPCM), which contains state variables for all the
> > pages in the Enclave Page Cache (EPC). The latter contains the pages,
> > which applications can use to create enclaves.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> >
> > ---
> > v2:
> > * Move ifdef fix for sgx_set_attribute() to a separate patch.
> > ---
> > Documentation/x86/sgx.rst | 6 ++++++
> > arch/x86/include/asm/sgx.h | 2 ++
> > arch/x86/kernel/cpu/sgx/main.c | 7 ++++++-
> > arch/x86/mm/pat/set_memory.c | 5 +++++
> > 4 files changed, 19 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/x86/sgx.rst b/Documentation/x86/sgx.rst
> > index dd0ac96ff9ef..68ee171e1d8f 100644
> > --- a/Documentation/x86/sgx.rst
> > +++ b/Documentation/x86/sgx.rst
> > @@ -250,3 +250,9 @@ user wants to deploy SGX applications both on the host and in guests
> > on the same machine, the user should reserve enough EPC (by taking out
> > total virtual EPC size of all SGX VMs from the physical EPC size) for
> > host SGX applications so they can run with acceptable performance.
> > +
> > +Supplemental fields for /proc/meminfo
> > +=====================================
> > +
> > +SGX_MemTotal
> > + The total usable SGX protected memory in kilobytes.
>
> Hi,
>
> I would prefer to see this listed in Documentation/filesystems/proc.rst
> as an optional field, depending on CONFIG_X86_SGX.
> Or at least put a reference in proc.rst to this doc file and its
> supplemental fields.
>
> thanks.
I *can* put it there but I did have reason not to, i.e. these attributes
are neither there:
DirectMap4k: 3930904 kB
DirectMap2M: 29440000 kB
DirectMap1G: 1048576 kB
And they are implemented in arch specific code.
Actually they are undocumented, e.g.
$ git grep DirectMap4k
arch/powerpc/mm/book3s64/pgtable.c: seq_printf(m, "DirectMap4k: %8lu kB\n",
arch/s390/mm/pageattr.c: seq_printf(m, "DirectMap4k: %8lu kB\n",
arch/x86/mm/pat/set_memory.c: seq_printf(m, "DirectMap4k: %8lu kB\n",
/Jarkko
next prev parent reply other threads:[~2021-08-26 16:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 23:52 [PATCH v3 1/2] x86/sgx: Add the missing ifdef for sgx_set_attribute() Jarkko Sakkinen
2021-08-25 23:52 ` [PATCH v3 2/2] x86/sgx: Add SGX_MemTotal to /proc/meminfo Jarkko Sakkinen
2021-08-26 0:39 ` Randy Dunlap
2021-08-26 16:17 ` Jarkko Sakkinen [this message]
2021-08-26 20:27 ` Dave Hansen
2021-08-26 22:27 ` Randy Dunlap
2021-09-01 1:51 ` Jarkko Sakkinen
2021-08-26 2:19 ` Kai Huang
2021-08-26 16:27 ` Jarkko Sakkinen
2021-08-27 12:03 ` Kai Huang
2021-09-01 2:02 ` Jarkko Sakkinen
2021-09-01 5:33 ` Kai Huang
2021-09-01 5:41 ` Jarkko Sakkinen
2021-09-01 5:47 ` Kai Huang
2021-09-02 12:15 ` Jarkko Sakkinen
2021-09-02 21:56 ` Kai Huang
2021-09-02 22:14 ` Jarkko Sakkinen
2021-08-26 9:58 ` [PATCH v3 1/2] x86/sgx: Add the missing ifdef for sgx_set_attribute() Borislav Petkov
2021-08-26 16:08 ` Jarkko Sakkinen
2021-08-26 16:35 ` Borislav Petkov
2021-08-26 17:11 ` Jarkko Sakkinen
2021-08-26 17:24 ` Borislav Petkov
2021-08-26 17:31 ` Jarkko Sakkinen
2021-08-26 17:53 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1ff36db0e7ed909653b6adb45094cc459dbad0b.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).