From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE7DC433DB for ; Tue, 16 Feb 2021 09:34:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03EB464DA3 for ; Tue, 16 Feb 2021 09:34:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229662AbhBPJeC convert rfc822-to-8bit (ORCPT ); Tue, 16 Feb 2021 04:34:02 -0500 Received: from mga03.intel.com ([134.134.136.65]:34795 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229907AbhBPJdz (ORCPT ); Tue, 16 Feb 2021 04:33:55 -0500 IronPort-SDR: 3K46jTKjgnYpjN+ajB8QNhXxnkoKsbSRL/hsZd7tToVuGToV5jXG58KUYRmxNNwXrbhtTe/0Pb EgYtXha+c2ng== X-IronPort-AV: E=McAfee;i="6000,8403,9896"; a="182917492" X-IronPort-AV: E=Sophos;i="5.81,183,1610438400"; d="scan'208";a="182917492" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2021 01:33:14 -0800 IronPort-SDR: 6WFS4cwYTI+ObYv/qp4BSvof2Bi80COztCBszkP7iuLyNVYXeoqDGtis/cJsTNiQgm4JRZlmKp eiQ5t1jKiXjg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,183,1610438400"; d="scan'208";a="580419873" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 16 Feb 2021 01:33:14 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 16 Feb 2021 01:33:13 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 16 Feb 2021 01:33:13 -0800 Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by ORSMSX602.amr.corp.intel.com ([10.22.229.15]) with mapi id 15.01.2106.002; Tue, 16 Feb 2021 01:33:13 -0800 From: "Huang, Kai" To: Jarkko Sakkinen CC: "linux-sgx@vger.kernel.org" , "kvm@vger.kernel.org" , "x86@kernel.org" , "seanjc@google.com" , "luto@kernel.org" , "Hansen, Dave" , "Edgecombe, Rick P" , "Huang, Haitao" , "pbonzini@redhat.com" , "bp@alien8.de" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" Subject: RE: [RFC PATCH v5 13/26] x86/sgx: Add helpers to expose ECREATE and EINIT to KVM Thread-Topic: [RFC PATCH v5 13/26] x86/sgx: Add helpers to expose ECREATE and EINIT to KVM Thread-Index: AQHXAgqQS1vAJ1WsIEqPe3ZtzCQoJapao/iAgAAARAD//5VNEIAAxTkAgAAAn4D//4ldcA== Date: Tue, 16 Feb 2021 09:33:13 +0000 Message-ID: References: <4b8921da8e0d037b1e99d5cc92eea8f8470cf2e0.1613221549.git.kai.huang@intel.com> <87b9c4bfe61545c0803f7a46b177e10e@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org > > > > > > +EXPORT_SYMBOL_GPL(sgx_virt_einit); > > > > > > > > Remove exports. > > > > > > Why? KVM needs to use them in later patches. > > > > Because they are only required for LKM's. > > I mean when LKM needs to call kernel functions. > > Right, KVM can be compiled as LKM. Just to confirm, you are OK with exposing them as symbol, since KVM (as a module) needs to use them, right?