From: "Haitao Huang" <haitao.huang@linux.intel.com>
To: linux-sgx@vger.kernel.org,
"Jarkko Sakkinen" <jarkko.sakkinen@linux.intel.com>
Cc: "Sean Christopherson" <sean.j.christopherson@intel.com>,
"Jethro Beekman" <jethro@fortanix.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH] x86/sgx: Remove checks for platform limits from sgx_validate_secs()
Date: Sun, 04 Oct 2020 23:00:28 -0500 [thread overview]
Message-ID: <op.0rzxe2jtwjvjmi@mqcpg7oapc828.gar.corp.intel.com> (raw)
In-Reply-To: <20201005020819.124724-1-jarkko.sakkinen@linux.intel.com>
On Sun, 04 Oct 2020 21:08:19 -0500, Jarkko Sakkinen
<jarkko.sakkinen@linux.intel.com> wrote:
> Remove from sgx_validate_secs():
>
> if (secs->miscselect & sgx_misc_reserved_mask ||
> secs->attributes & sgx_attributes_reserved_mask ||
> secs->xfrm & sgx_xfrm_reserved_mask)
> return -EINVAL;
>
> SECS can surpass the platform limits because it's the SIGSTRUCT that
> defines the limits that are used at run-time.
>
> What SECS does is that it defines the overall limits that must apply for
> any platform, i.e. SECS limits and platform limits are orthogonal. They
> are not dependent.
>
> Cc: Sean Christopherson <sean.j.christopherson@intel.com>
> Cc: Jethro Beekman <jethro@fortanix.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Suggested-by: Haitao Huang <haitao.huang@linux.intel.com>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> ---
> arch/x86/kernel/cpu/sgx/ioctl.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/sgx/ioctl.c
> b/arch/x86/kernel/cpu/sgx/ioctl.c
> index 6b3cc8483008..008752cb54f0 100644
> --- a/arch/x86/kernel/cpu/sgx/ioctl.c
> +++ b/arch/x86/kernel/cpu/sgx/ioctl.c
> @@ -86,11 +86,6 @@ static int sgx_validate_secs(const struct sgx_secs
> *secs)
> if (secs->base & (secs->size - 1))
> return -EINVAL;
> - if (secs->miscselect & sgx_misc_reserved_mask ||
> - secs->attributes & sgx_attributes_reserved_mask ||
> - secs->xfrm & sgx_xfrm_reserved_mask)
> - return -EINVAL;
> -
> if (secs->size > max_size)
> return -EINVAL;
>
Looks good to me.
Thanks
Haitao
next prev parent reply other threads:[~2020-10-05 4:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 2:08 [PATCH] x86/sgx: Remove checks for platform limits from sgx_validate_secs() Jarkko Sakkinen
2020-10-05 2:29 ` Jarkko Sakkinen
2020-10-05 4:00 ` Haitao Huang [this message]
2020-10-05 11:38 ` Jarkko Sakkinen
2020-10-05 22:46 ` Sean Christopherson
2020-10-06 15:16 ` Jarkko Sakkinen
2020-10-06 15:32 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.0rzxe2jtwjvjmi@mqcpg7oapc828.gar.corp.intel.com \
--to=haitao.huang@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jethro@fortanix.com \
--cc=linux-sgx@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).