From: "Haitao Huang" <haitao.huang@linux.intel.com>
To: jarkko@kernel.org, dave.hansen@linux.intel.com, tj@kernel.org,
mkoutny@suse.com, linux-kernel@vger.kernel.org,
linux-sgx@vger.kernel.org, x86@kernel.org,
cgroups@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com, sohil.mehta@intel.com,
"Tim Chen" <tim.c.chen@linux.intel.com>
Cc: zhiquan1.li@intel.com, kristen@linux.intel.com,
seanjc@google.com, zhanb@microsoft.com, anakrish@microsoft.com,
mikko.ylinen@linux.intel.com, yangjie@microsoft.com
Subject: Re: [PATCH v7 09/15] x86/sgx: Charge mem_cgroup for per-cgroup reclamation
Date: Fri, 02 Feb 2024 18:39:23 -0600 [thread overview]
Message-ID: <op.2ijirxjlwjvjmi@hhuan26-mobl.amr.corp.intel.com> (raw)
In-Reply-To: <ca25d3462944dcea553665d7c85903cdd6a846bc.camel@linux.intel.com>
Hi Tim,
On Fri, 02 Feb 2024 17:45:05 -0600, Tim Chen <tim.c.chen@linux.intel.com>
wrote:
> On Mon, 2024-01-22 at 09:20 -0800, Haitao Huang wrote:
>>
>> @@ -1047,29 +1037,38 @@ static struct mem_cgroup
>> *sgx_encl_get_mem_cgroup(struct sgx_encl *encl)
>> * @encl: an enclave pointer
>> * @page_index: enclave page index
>> * @backing: data for accessing backing storage for the page
>> + * @indirect: in ksgxd or EPC cgroup work queue context
>> + *
>> + * Create a backing page for loading data back into an EPC page with
>> ELDU. This function takes
>> + * a reference on a new backing page which must be dropped with a
>> corresponding call to
>> + * sgx_encl_put_backing().
>> *
>> - * When called from ksgxd, sets the active memcg from one of the
>> - * mms in the enclave's mm_list prior to any backing page allocation,
>> - * in order to ensure that shmem page allocations are charged to the
>> - * enclave. Create a backing page for loading data back into an EPC
>> page with
>> - * ELDU. This function takes a reference on a new backing page which
>> - * must be dropped with a corresponding call to sgx_encl_put_backing().
>> + * When @indirect is true, sets the active memcg from one of the mms
>> in the enclave's mm_list
>> + * prior to any backing page allocation, in order to ensure that shmem
>> page allocations are
>> + * charged to the enclave.
>> *
>> * Return:
>> * 0 on success,
>> * -errno otherwise.
>> */
>> int sgx_encl_alloc_backing(struct sgx_encl *encl, unsigned long
>> page_index,
>> - struct sgx_backing *backing)
>> + struct sgx_backing *backing, bool indirect)
>> {
>> - struct mem_cgroup *encl_memcg = sgx_encl_get_mem_cgroup(encl);
>> - struct mem_cgroup *memcg = set_active_memcg(encl_memcg);
>> + struct mem_cgroup *encl_memcg;
>> + struct mem_cgroup *memcg;
>> int ret;
>>
>> + if (indirect) {
>> + encl_memcg = sgx_encl_get_mem_cgroup(encl);
>> + memcg = set_active_memcg(encl_memcg);
>> + }
>> +
>> ret = __sgx_encl_get_backing(encl, page_index, backing);
>>
>> - set_active_memcg(memcg);
>> - mem_cgroup_put(encl_memcg);
>> + if (indirect) {
>> + set_active_memcg(memcg);
>> + mem_cgroup_put(encl_memcg);
>> + }
>>
>
>
> You can reduce the number of if statements to make the logic
> simpler. Something like
>
> if (!indirect)
> return __sgx_encl_get_backing(encl, page_index, backing);
>
> encl_memcg = sgx_encl_get_mem_cgroup(encl);
> memcg = set_active_memcg(encl_memcg);
> ret = __sgx_encl_get_backing(encl, page_index, backing);
> set_active_memcg(memcg);
> mem_cgroup_put(encl_memcg);
>
>> return ret;
>
> Tim
>
Yes, will do.
Thanks
Haitao
next prev parent reply other threads:[~2024-02-03 0:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 17:20 [PATCH v7 00/15] Add Cgroup support for SGX EPC memory Haitao Huang
2024-01-22 17:20 ` [PATCH v7 01/15] cgroup/misc: Add per resource callbacks for CSS events Haitao Huang
2024-01-22 20:14 ` Jarkko Sakkinen
2024-01-23 16:19 ` Haitao Huang
2024-01-22 17:20 ` [PATCH v7 02/15] cgroup/misc: Export APIs for SGX driver Haitao Huang
2024-01-22 20:17 ` Jarkko Sakkinen
2024-01-22 17:20 ` [PATCH v7 03/15] cgroup/misc: Add SGX EPC resource type Haitao Huang
2024-01-22 20:18 ` Jarkko Sakkinen
2024-01-22 17:20 ` [PATCH v7 04/15] x86/sgx: Implement basic EPC misc cgroup functionality Haitao Huang
2024-01-22 20:25 ` Jarkko Sakkinen
2024-01-23 16:04 ` Haitao Huang
2024-01-24 3:29 ` Haitao Huang
2024-02-01 23:21 ` Jarkko Sakkinen
2024-01-22 17:20 ` [PATCH v7 05/15] x86/sgx: Add sgx_epc_lru_list to encapsulate LRU list Haitao Huang
2024-01-22 17:20 ` [PATCH v7 06/15] x86/sgx: Abstract tracking reclaimable pages in LRU Haitao Huang
2024-01-22 17:20 ` [PATCH v7 07/15] x86/sgx: Expose sgx_reclaim_pages() for cgroup Haitao Huang
2024-01-22 20:28 ` Jarkko Sakkinen
2024-01-22 17:20 ` [PATCH v7 08/15] x86/sgx: Implement EPC reclamation flows " Haitao Huang
2024-01-22 20:29 ` Jarkko Sakkinen
2024-01-22 17:20 ` [PATCH v7 09/15] x86/sgx: Charge mem_cgroup for per-cgroup reclamation Haitao Huang
2024-01-22 20:30 ` Jarkko Sakkinen
2024-01-26 14:37 ` Huang, Kai
2024-01-26 16:21 ` Haitao Huang
2024-02-02 23:45 ` Tim Chen
2024-02-03 0:39 ` Haitao Huang [this message]
2024-01-22 17:20 ` [PATCH v7 10/15] x86/sgx: Add EPC reclamation in cgroup try_charge() Haitao Huang
2024-01-22 17:20 ` [PATCH v7 11/15] x86/sgx: Abstract check for global reclaimable pages Haitao Huang
2024-01-22 17:20 ` [PATCH v7 12/15] x86/sgx: Expose sgx_epc_cgroup_reclaim_pages() for global reclaimer Haitao Huang
2024-01-22 20:31 ` Jarkko Sakkinen
2024-01-22 17:20 ` [PATCH v7 13/15] x86/sgx: Turn on per-cgroup EPC reclamation Haitao Huang
2024-01-22 17:20 ` [PATCH v7 14/15] Docs/x86/sgx: Add description for cgroup support Haitao Huang
2024-01-22 17:20 ` [PATCH v7 15/15] selftests/sgx: Add scripts for EPC cgroup testing Haitao Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.2ijirxjlwjvjmi@hhuan26-mobl.amr.corp.intel.com \
--to=haitao.huang@linux.intel.com \
--cc=anakrish@microsoft.com \
--cc=bp@alien8.de \
--cc=cgroups@vger.kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=kristen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mikko.ylinen@linux.intel.com \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=seanjc@google.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
--cc=yangjie@microsoft.com \
--cc=zhanb@microsoft.com \
--cc=zhiquan1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).