linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: Arnd Bergmann <arnd@kernel.org>, linux-arch@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Vineet Gupta <vgupta@synopsys.com>, Arnd Bergmann <arnd@arndb.de>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 03/12] sh: remove unaligned access for sh4a
Date: Mon, 10 May 2021 16:11:03 -0500	[thread overview]
Message-ID: <1b1d34a8-d170-7287-1c99-40d2af83d1b9@landley.net> (raw)
In-Reply-To: <20210507220813.365382-4-arnd@kernel.org>

On 5/7/21 5:07 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Unlike every other architecture, sh4a uses an inline asm implementation
> for get_unaligned(). I have shown that this produces better object
> code than the asm-generic version. However, there are very few users of
> arch/sh/ overall, and most of those seem to use sh4 rather than sh4a CPU

Hitachi's sh4, sh3, and sh2 are all out of patent, and have been cloned as open
hardware. (Modulo the sh4 clone uses a different mmu design, but lots of
regression testing gets done against qemu-system-sh4 and sh4 hardware using the
original mmu.) Plus superh was the bestselling CPU architecture in the world for
3 years back in the 1990s, and there's a remaining userbase from that.

sh5 and the "a" designs like sh4a were created by renesas after hitachi spun off
the IP to them, and are not out of patent. I do not have access to an sh4a test
system.

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/sh/include/asm/unaligned-sh4a.h | 199 ---------------------------
>  arch/sh/include/asm/unaligned.h      |  13 --

All I can test is that it didn't cause regressions on my sh4 and j-core systems,
which it (unsurprisingly) did not.

Acked-by: Rob Landley <rob@landley.net>

Rob

  reply	other threads:[~2021-05-10 20:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07 22:07 [RFC 0/12] Unify asm/unaligned.h around struct helper Arnd Bergmann
2021-05-07 22:07 ` [RFC 03/12] sh: remove unaligned access for sh4a Arnd Bergmann
2021-05-10 21:11   ` Rob Landley [this message]
2021-05-07 22:07 ` [RFC 0/12] Unify asm/unaligned.h around struct helper Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b1d34a8-d170-7287-1c99-40d2af83d1b9@landley.net \
    --to=rob@landley.net \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=dalias@libc.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vgupta@synopsys.com \
    --cc=ysato@users.sourceforge.jp \
    --subject='Re: [RFC 03/12] sh: remove unaligned access for sh4a' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).