From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Date: Thu, 09 Jul 2020 09:18:15 +0000 Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory Message-Id: <20200709091815.GF781326@linux.ibm.com> List-Id: References: <20200709020629.91671-1-justin.he@arm.com> <20200709020629.91671-5-justin.he@arm.com> <20200709021104.GZ25523@casper.infradead.org> In-Reply-To: <20200709021104.GZ25523@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthew Wilcox Cc: Rich Felker , linux-ia64@vger.kernel.org, David Hildenbrand , Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm@kvack.org, Michal Hocko , "H. Peter Anvin" , Will Deacon , Thomas Gleixner , Jia He , Yoshinori Sato , linux-nvdimm@lists.01.org, linux-sh@vger.kernel.org, Vishal Verma , Masahiro Yamada , x86@kernel.org, Kaly Xin , Ingo Molnar , Fenghua Yu , Chuhong Yuan , Borislav Petkov , Andy Lutomirski , Jonathan Cameron , Dave Jiang , Dan Williams , linux-arm-kernel@lists.infradead.org, Tony Luck , Baoquan He , linux-kernel@vger.kernel.org, Andrew Morton , Logan Gunthorpe On Thu, Jul 09, 2020 at 03:11:04AM +0100, Matthew Wilcox wrote: > On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > > After a general version of __weak memory_add_physaddr_to_nid implemented > > and exported , it is no use exporting twice in arch directory even if > > e,g, ia64/x86 have their specific version. > > > > This is to suppress the modpost warning: > > WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > > Previous export was in vmlinux > > It's bad form to introduce a warning and then send a follow-up patch to > fix the warning. Just fold this patch into patch 1/6. Moreover, I think that patches 1-4 can be merged into one. -- Sincerely yours, Mike.