From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ira Weiny <ira.weiny@intel.com>, "David S. Miller" <davem@davemloft.net>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Geoff Levand <geoff@infradead.org>,
Ilya Dryomov <idryomov@gmail.com>,
Dongsheng Yang <dongsheng.yang@easystack.cn>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-arch@vger.kernel.org, Tero Kristo <t-kristo@ti.com>,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-sh@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 09/16] ps3disk: use memcpy_{from,to}_bvec
Date: Tue, 15 Jun 2021 13:02:59 +0800 [thread overview]
Message-ID: <20210615050258.GA5208@gondor.apana.org.au> (raw)
In-Reply-To: <20210612040743.GG1600546@iweiny-DESK2.sc.intel.com>
On Fri, Jun 11, 2021 at 09:07:43PM -0700, Ira Weiny wrote:
>
> More recently this was added:
>
> 7e34e0bbc644 crypto: omap-crypto - fix userspace copied buffer access
>
> I'm CC'ing Tero and Herbert to see why they added the SLAB check.
Probably because the generic Crypto API has the same check. This
all goes back to
commit 4f3e797ad07d52d34983354a77b365dfcd48c1b4
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon Feb 9 14:22:14 2009 +1100
crypto: scatterwalk - Avoid flush_dcache_page on slab pages
It's illegal to call flush_dcache_page on slab pages on a number
of architectures. So this patch avoids doing so if PageSlab is
true.
In future we can move the flush_dcache_page call to those page
cache users that actually need it.
Reported-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
But I can't find any emails discussing this so let me ask Dave
directly and see if he can tell us what the issue was or might
have been.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2021-06-15 5:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210608160603.1535935-1-hch@lst.de>
[not found] ` <20210608160603.1535935-10-hch@lst.de>
[not found] ` <20210609014822.GT3697498@iweiny-DESK2.sc.intel.com>
[not found] ` <20210611065338.GA31210@lst.de>
2021-06-12 4:07 ` [PATCH 09/16] ps3disk: use memcpy_{from,to}_bvec Ira Weiny
2021-06-15 5:02 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615050258.GA5208@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=dongsheng.yang@easystack.cn \
--cc=geoff@infradead.org \
--cc=hch@lst.de \
--cc=idryomov@gmail.com \
--cc=ira.weiny@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=snitzer@redhat.com \
--cc=t-kristo@ti.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).