From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5191BC76195 for ; Thu, 16 Mar 2023 19:04:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229556AbjCPTEB (ORCPT ); Thu, 16 Mar 2023 15:04:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbjCPTD6 (ORCPT ); Thu, 16 Mar 2023 15:03:58 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E882E2517; Thu, 16 Mar 2023 12:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678993428; x=1710529428; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=zUzkGxrqKDPR6SroJseKwSx7MVAGnpL/Grdhlw6b7UE=; b=GGGcwcWFhVNUPqlV5cS7jhSo++oAJJeSo+qf8YGM9dLprFCOO90c7NMm e8AhBjSiTxfCcsA0O81ZpHm5F4j+gpsUAI9H1C81Sv7zAKj5/fHr1lai4 hEbgqNKOh6T2ENt2DM/sliOpWhZNXF1cX+UNrAZYnmO59Wa+ehb4oCZJd bQ6irRFzgXO/MfQ1FFy326yiwnl/C2t1daZQ4tx/KhKcHBV7DzcLjin0g 3ddESbDNI/pjbsLY+8U2qN/0vrXedmDzmX7lS/nykk7GfmB6WVFfSiZmh zoOpHKx6VD5zBdoQp5tLxiS4ZMFiN3xNtXzlWPkv8RD4F3aXnH27TcJ5N g==; X-IronPort-AV: E=McAfee;i="6600,9927,10651"; a="321944554" X-IronPort-AV: E=Sophos;i="5.98,265,1673942400"; d="scan'208";a="321944554" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2023 12:03:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10651"; a="925864625" X-IronPort-AV: E=Sophos;i="5.98,265,1673942400"; d="scan'208";a="925864625" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga006.fm.intel.com with ESMTP; 16 Mar 2023 12:03:40 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pcst1-0008hW-1B; Thu, 16 Mar 2023 19:03:39 +0000 Date: Fri, 17 Mar 2023 03:03:04 +0800 From: kernel test robot To: Andy Shevchenko , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Niklas Schnelle , Bjorn Helgaas , "Rafael J. Wysocki" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn Subject: Re: [PATCH v5 1/4] PCI: Introduce pci_dev_for_each_resource() Message-ID: <202303170223.V0xQhs1V-lkp@intel.com> References: <20230314192634.63531-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230314192634.63531-2-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on pci/for-linus powerpc/next powerpc/fixes linus/master v6.3-rc2 next-20230316] [cannot apply to soc/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/PCI-Introduce-pci_dev_for_each_resource/20230315-032821 base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next patch link: https://lore.kernel.org/r/20230314192634.63531-2-andriy.shevchenko%40linux.intel.com patch subject: [PATCH v5 1/4] PCI: Introduce pci_dev_for_each_resource() config: powerpc-randconfig-r032-20230312 (https://download.01.org/0day-ci/archive/20230317/202303170223.V0xQhs1V-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc cross compiling tool for clang build # apt-get install binutils-powerpc-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/85cdf4746b716f7b6c14d7dc5cd907c3c2a1fb0c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/PCI-Introduce-pci_dev_for_each_resource/20230315-032821 git checkout 85cdf4746b716f7b6c14d7dc5cd907c3c2a1fb0c # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303170223.V0xQhs1V-lkp@intel.com/ All errors (new ones prefixed by >>): >> arch/powerpc/platforms/52xx/mpc52xx_pci.c:331:6: error: unused variable 'i' [-Werror,-Wunused-variable] int i; ^ 1 error generated. vim +/i +331 arch/powerpc/platforms/52xx/mpc52xx_pci.c f42963f8646540 Grant Likely 2006-12-12 326 f42963f8646540 Grant Likely 2006-12-12 327 static void f42963f8646540 Grant Likely 2006-12-12 328 mpc52xx_pci_fixup_resources(struct pci_dev *dev) f42963f8646540 Grant Likely 2006-12-12 329 { 85cdf4746b716f Mika Westerberg 2023-03-14 330 struct resource *res; f42963f8646540 Grant Likely 2006-12-12 @331 int i; f42963f8646540 Grant Likely 2006-12-12 332 59510820fff76f Randy Dunlap 2021-04-28 333 pr_debug("%s() %.4x:%.4x\n", __func__, dev->vendor, dev->device); f42963f8646540 Grant Likely 2006-12-12 334 f42963f8646540 Grant Likely 2006-12-12 335 /* We don't rely on boot loader for PCI and resets all f42963f8646540 Grant Likely 2006-12-12 336 devices */ 85cdf4746b716f Mika Westerberg 2023-03-14 337 pci_dev_for_each_resource_p(dev, res) { f42963f8646540 Grant Likely 2006-12-12 338 if (res->end > res->start) { /* Only valid resources */ f42963f8646540 Grant Likely 2006-12-12 339 res->end -= res->start; f42963f8646540 Grant Likely 2006-12-12 340 res->start = 0; f42963f8646540 Grant Likely 2006-12-12 341 res->flags |= IORESOURCE_UNSET; f42963f8646540 Grant Likely 2006-12-12 342 } f42963f8646540 Grant Likely 2006-12-12 343 } f42963f8646540 Grant Likely 2006-12-12 344 f42963f8646540 Grant Likely 2006-12-12 345 /* The PCI Host bridge of MPC52xx has a prefetch memory resource f42963f8646540 Grant Likely 2006-12-12 346 fixed to 1Gb. Doesn't fit in the resource system so we remove it */ f42963f8646540 Grant Likely 2006-12-12 347 if ( (dev->vendor == PCI_VENDOR_ID_MOTOROLA) && f42963f8646540 Grant Likely 2006-12-12 348 ( dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200 f42963f8646540 Grant Likely 2006-12-12 349 || dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200B) ) { f42963f8646540 Grant Likely 2006-12-12 350 struct resource *res = &dev->resource[1]; f42963f8646540 Grant Likely 2006-12-12 351 res->start = res->end = res->flags = 0; f42963f8646540 Grant Likely 2006-12-12 352 } f42963f8646540 Grant Likely 2006-12-12 353 } f42963f8646540 Grant Likely 2006-12-12 354 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests