From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-sh list <linux-sh@vger.kernel.org>,
Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: Implement __get_user_u64() required for 64-bit get_user()
Date: Sun, 31 May 2020 09:59:14 +0000 [thread overview]
Message-ID: <2ad089c1-75cf-0986-c40f-c7f3f8fd6ead@physik.fu-berlin.de> (raw)
In-Reply-To: <ba354e30-82ab-68c2-0771-2489463c9279@physik.fu-berlin.de>
On 5/31/20 11:54 AM, John Paul Adrian Glaubitz wrote:
> Hi Geert!
>
> On 5/31/20 11:52 AM, Geert Uytterhoeven wrote:
>> As this is the 64-bit variant, I think this single move should be
>> replaced by a double move:
>>
>> "mov #0,%R1\n\t" \
>> "mov #0,%S1\n\t" \
>>
>> Same for the big endian version below.
>>
>> Disclaimer: uncompiled, untested, no SH assembler expert.
>
> Right, this makes sense. I'll send a new patch shortly.
Hmm, this change is not the case for __put_user_asm() vs. __put_user_u64().
But I have to admit, I don't know what the part below "3:\n\t" is for.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
next prev parent reply other threads:[~2020-05-31 9:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 17:45 [RESEND] sh: Implement __get_user_u64() required for 64-bit get_user() John Paul Adrian Glaubitz
2020-05-29 17:45 ` [PATCH] " John Paul Adrian Glaubitz
2020-05-31 9:52 ` Geert Uytterhoeven
2020-05-31 9:54 ` John Paul Adrian Glaubitz
2020-05-31 9:59 ` John Paul Adrian Glaubitz [this message]
2020-05-31 10:43 ` Geert Uytterhoeven
2020-05-31 10:52 ` John Paul Adrian Glaubitz
2020-06-01 3:03 ` Rich Felker
2020-06-01 9:02 ` Geert Uytterhoeven
2020-06-01 9:13 ` John Paul Adrian Glaubitz
2020-06-01 16:57 ` Rich Felker
2020-06-01 20:26 ` Michael Karcher
2020-06-01 20:50 ` Rich Felker
2020-06-02 10:19 ` Michael Karcher
-- strict thread matches above, loose matches on Subject: below --
2020-06-11 7:58 [PATCH v3] " John Paul Adrian Glaubitz
2020-06-11 7:58 ` [PATCH] " John Paul Adrian Glaubitz
2020-06-27 15:26 ` Yoshinori Sato
2020-05-29 17:34 John Paul Adrian Glaubitz
2020-05-29 17:34 ` [PATCH] sh: Implement __get_user_u64() required for 64-bit get_user() John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ad089c1-75cf-0986-c40f-c7f3f8fd6ead@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=kernel@mkarcher.dialup.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).