From: David Hildenbrand <david@redhat.com>
To: Arvind Sankar <nivedita@alum.mit.edu>,
x86@kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-sh@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
sparclinux@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] x86/mm: Drop unused MAX_PHYSADDR_BITS
Date: Fri, 24 Jul 2020 08:22:36 +0000 [thread overview]
Message-ID: <45ec14e7-fd5b-f4f9-6f61-94a9159ec3ad@redhat.com> (raw)
In-Reply-To: <20200723231544.17274-2-nivedita@alum.mit.edu>
On 24.07.20 01:15, Arvind Sankar wrote:
> The macro is not used anywhere, and has an incorrect value (going by the
> comment) on x86_64 since commit
> c898faf91b3e ("x86: 46 bit physical address support on 64 bits")
>
> To avoid confusion, just remove the definition.
>
> Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
> ---
> arch/x86/include/asm/sparsemem.h | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/x86/include/asm/sparsemem.h b/arch/x86/include/asm/sparsemem.h
> index 199218719a86..6bfc878f6771 100644
> --- a/arch/x86/include/asm/sparsemem.h
> +++ b/arch/x86/include/asm/sparsemem.h
> @@ -10,24 +10,20 @@
> * field of the struct page
> *
> * SECTION_SIZE_BITS 2^n: size of each section
> - * MAX_PHYSADDR_BITS 2^n: max size of physical address space
> - * MAX_PHYSMEM_BITS 2^n: how much memory we can have in that space
> + * MAX_PHYSMEM_BITS 2^n: max size of physical address space
> *
> */
>
> #ifdef CONFIG_X86_32
> # ifdef CONFIG_X86_PAE
> # define SECTION_SIZE_BITS 29
> -# define MAX_PHYSADDR_BITS 36
> # define MAX_PHYSMEM_BITS 36
> # else
> # define SECTION_SIZE_BITS 26
> -# define MAX_PHYSADDR_BITS 32
> # define MAX_PHYSMEM_BITS 32
> # endif
> #else /* CONFIG_X86_32 */
> # define SECTION_SIZE_BITS 27 /* matt - 128 is convenient right now */
> -# define MAX_PHYSADDR_BITS (pgtable_l5_enabled() ? 52 : 44)
> # define MAX_PHYSMEM_BITS (pgtable_l5_enabled() ? 52 : 46)
> #endif
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-07-24 8:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 23:15 [PATCH 0/3] Drop unused MAX_PHYSADDR_BITS Arvind Sankar
2020-07-23 23:15 ` [PATCH 1/3] x86/mm: " Arvind Sankar
2020-07-24 8:22 ` David Hildenbrand [this message]
2020-07-23 23:15 ` [PATCH 2/3] sh/mm: " Arvind Sankar
2020-07-24 8:22 ` David Hildenbrand
2020-07-23 23:15 ` [PATCH 3/3] sparc: " Arvind Sankar
2020-07-24 8:22 ` David Hildenbrand
2020-07-24 23:37 ` David Miller
2020-07-24 15:04 ` [PATCH 0/3] " Dave Hansen
2020-07-26 6:48 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ec14e7-fd5b-f4f9-6f61-94a9159ec3ad@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sh@vger.kernel.org \
--cc=luto@kernel.org \
--cc=nivedita@alum.mit.edu \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).