From: viresh kumar <viresh.kumar@st.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] clk: Add a generic clock infrastructure
Date: Tue, 24 May 2011 04:30:12 +0000 [thread overview]
Message-ID: <4DDB3184.2080301@st.com> (raw)
In-Reply-To: <1305876469.326305.518470530485.1.gpush@pororo>
On 05/20/2011 12:57 PM, Jeremy Kerr wrote:
> +static DEFINE_SPINLOCK(enable_lock);
> +static DEFINE_MUTEX(prepare_lock);
Probably all clocks can be handled separately, i.e. single lock for all
of them will make system slower. Suppose i want to enable UART's clock
then why should spi code be waiting for the lock.
So, we should have per clk lock.
<...>
> +struct clk *clk_register(struct clk_hw_ops *ops, struct clk_hw *hw,
> + const char *name)
> +{
> + struct clk *clk;
> +
> + clk = kzalloc(sizeof(*clk), GFP_KERNEL);
> + if (!clk)
> + return NULL;
> +
> + clk->name = name;
> + clk->ops = ops;
> + clk->hw = hw;
> + hw->clk = clk;
> +
> + /* Query the hardware for parent and initial rate */
> +
Can remove this blank line.
> + if (clk->ops->get_parent)
> + /* We don't to lock against prepare/enable here, as
> + * the clock is not yet accessible from anywhere */
Shouldn't we use following style for multi-line comments.
/*
* ....
*/
> + clk->parent = clk->ops->get_parent(clk->hw);
> +
> + if (clk->ops->recalc_rate)
> + clk->rate = clk->ops->recalc_rate(clk->hw);
> +
> +
Can remove one of these blank lines.
--
viresh
next prev parent reply other threads:[~2011-05-24 4:30 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 7:27 [PATCH 0/4] Add a generic struct clk Jeremy Kerr
2011-05-20 7:27 ` [PATCH 4/4] clk: Add simple gated clock Jeremy Kerr
2011-05-20 11:37 ` Arnd Bergmann
2011-05-20 22:19 ` Rob Herring
2011-05-20 7:27 ` [PATCH 2/4] clk: Implement clk_set_rate Jeremy Kerr
2011-05-20 12:25 ` Sascha Hauer
2011-05-24 7:59 ` Colin Cross
2011-05-25 19:03 ` Sascha Hauer
[not found] ` <1306373867.2875.162.camel@pororo>
2011-05-26 6:54 ` Sascha Hauer
2011-05-30 5:05 ` Mike Frysinger
2011-05-20 7:27 ` [PATCH 3/4] clk: Add fixed-rate clock Jeremy Kerr
2011-05-30 5:01 ` Mike Frysinger
2011-05-30 5:02 ` Mike Frysinger
2011-05-20 7:27 ` [PATCH 1/4] clk: Add a generic clock infrastructure Jeremy Kerr
2011-05-20 11:59 ` Sascha Hauer
2011-05-20 13:25 ` Thomas Gleixner
2011-05-20 13:36 ` Sascha Hauer
2011-05-23 23:55 ` Colin Cross
2011-05-24 7:02 ` Sascha Hauer
2011-05-24 7:51 ` Colin Cross
2011-05-24 8:38 ` Sascha Hauer
2011-05-25 11:22 ` Richard Zhao
2011-05-25 11:43 ` Thomas Gleixner
2011-05-24 4:30 ` viresh kumar [this message]
2011-05-25 10:47 ` Richard Zhao
2011-05-30 5:00 ` Mike Frysinger
2011-05-23 23:12 ` [PATCH 0/4] Add a generic struct clk Colin Cross
2011-05-24 6:26 ` Sascha Hauer
2011-05-24 7:31 ` Colin Cross
2011-05-24 8:09 ` Sascha Hauer
2011-05-24 19:41 ` Colin Cross
2011-05-25 2:32 ` Richard Zhao
2011-05-25 6:23 ` Sascha Hauer
2011-05-25 7:51 ` Thomas Gleixner
2011-05-27 14:39 ` Mark Brown
2011-05-24 17:22 ` Richard Zhao
2011-05-24 17:52 ` Colin Cross
2011-05-25 2:08 ` Richard Zhao
2011-05-30 5:20 ` Mike Frysinger
2011-07-10 9:09 ` Mark Brown
2011-07-10 9:50 ` Russell King - ARM Linux
2011-07-10 10:00 ` Russell King - ARM Linux
2011-07-10 11:27 ` Mark Brown
2011-07-10 11:52 ` Russell King - ARM Linux
2011-07-11 2:49 ` Jeremy Kerr
2011-07-11 3:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDB3184.2080301@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).