linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: linux-sh@vger.kernel.org
Subject: Re: Pull Request for 5.9
Date: Sun, 09 Aug 2020 13:37:16 +0000	[thread overview]
Message-ID: <7ac6117a-fc51-ad6b-11b3-a4a8eed3a781@physik.fu-berlin.de> (raw)
In-Reply-To: <16a9b527-e05c-dcac-86bd-b79be140c053@physik.fu-berlin.de>

Hi Rich!

Building -next on SH is currently broken:

make[1]: 'include/generated/machtypes.h' is up to date.
  CALL    scripts/checksyscalls.sh
<stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
  CALL    scripts/atomic/check-atomics.sh
  CHK     include/generated/compile.h
  CC      arch/sh/kernel/ptrace_32.o
arch/sh/kernel/ptrace_32.c:168:5: error: conflicting types for ‘fpregs_get’
  168 | int fpregs_get(struct task_struct *target,
      |     ^~~~~~~~~~
In file included from arch/sh/kernel/ptrace_32.c:31:
./arch/sh/include/asm/fpu.h:40:12: note: previous declaration of ‘fpregs_get’ was here
   40 | extern int fpregs_get(struct task_struct *target,
      |            ^~~~~~~~~~
make[1]: *** [scripts/Makefile.build:283: arch/sh/kernel/ptrace_32.o] Error 1
make: *** [Makefile:1789: arch/sh/kernel] Error 2

This regression was introduced by:

commit 3399d90ce63edf7439900db50b5c02aa822f190b
Author: Al Viro <viro@zeniv.linux.org.uk>
Date:   Tue Jun 16 00:54:51 2020 -0400

    sh: convert to ->regset_get()

    NB: there's a direct call of fpregs_get() left in dump_fpu().
    To be taken out once we convert ELF_FDPIC to use of regset.

    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

 arch/sh/kernel/process_32.c |  5 ++---
 arch/sh/kernel/ptrace_32.c  | 48 ++++++++++-----------------------------------
 2 files changed, 12 insertions(+), 41 deletions(-)

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

  parent reply	other threads:[~2020-08-09 13:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-07  7:36 Pull Request for 5.9 John Paul Adrian Glaubitz
2020-08-07 18:34 ` Rich Felker
2020-08-07 18:35 ` John Paul Adrian Glaubitz
2020-08-09 13:37 ` John Paul Adrian Glaubitz [this message]
2020-08-10 13:06 ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ac6117a-fc51-ad6b-11b3-a4a8eed3a781@physik.fu-berlin.de \
    --to=glaubitz@physik.fu-berlin.de \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).