From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F3CEC43219 for ; Sat, 5 Nov 2022 21:13:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230179AbiKEVNy (ORCPT ); Sat, 5 Nov 2022 17:13:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230224AbiKEVNe (ORCPT ); Sat, 5 Nov 2022 17:13:34 -0400 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BF4113CC4 for ; Sat, 5 Nov 2022 14:13:33 -0700 (PDT) Received: by mail-qk1-x736.google.com with SMTP id l9so5249125qkk.11 for ; Sat, 05 Nov 2022 14:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oAUSnUna3zS1fBFrtEIiCL0CSikhXV9H9gl4bxAoOlg=; b=ZuJIeLB+J2B+Wi1b1yHoLdNdJG615BQeh3CPU6LD93y3msmDVTjWdZW9SDWuwWG0Ca YhJ+P7666j6kD5Xt3qGOHQOk6MqT4dr6x8NEoIAvnzfrmsju0oEob+uN+nSjB06pGmVE 9YOPL0fQ+TfTab0XaBhkdWiy9kYH1H39RsusA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oAUSnUna3zS1fBFrtEIiCL0CSikhXV9H9gl4bxAoOlg=; b=tMQCR+LsbpIHGH+MBv0c7BFkg8wUU9d9GuHDezOgmC/Cf8KL4oeY7WOE3iKWDI3pUc T5zgnxeeK2WQY+cC9e2U9asjnQEqiaz72RJe1MYxSjeB62cPrbM6aAEDyaU3YvKYvSTp zZD+mahm0800REbYIgZQ5q5K6Av8m3CSJ+cxzGxGkhNTbBjMAEojKAnJlABzx8EpDjex 1hSNQcrgSOQxpA0Ez7D/0QB2PmhFWucJnCjCAL5M0r//BCd8OFZ+zswdbigDgcU84iiO wClvlCefrfZH7rL2nL2Ia7eZ+XCUQKNi9MBk7rdgeyAoLFTC/rFQVXtjbx4I2+NpBTNl JanA== X-Gm-Message-State: ACrzQf18uAnw6zpPhRr7BaFHN+n5AZgLEUhaieEOXEK3bTtI9mI4gs9T BwXtYUhTpXalalaccOM0VO+VvDZpl+VyFw== X-Google-Smtp-Source: AMsMyM6k4d41RAoaN7YFIf/W3a1/D4RtDhS2u/WJQ15sUZpnOcTfKBIHoI8ei2CL/oFGh6XG0RGTHg== X-Received: by 2002:a05:620a:13e1:b0:6fa:3f2c:c62e with SMTP id h1-20020a05620a13e100b006fa3f2cc62emr21920418qkl.251.1667682812016; Sat, 05 Nov 2022 14:13:32 -0700 (PDT) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com. [209.85.219.173]) by smtp.gmail.com with ESMTPSA id x17-20020a05620a449100b006fa31bf2f3dsm2809346qkp.47.2022.11.05.14.13.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Nov 2022 14:13:31 -0700 (PDT) Received: by mail-yb1-f173.google.com with SMTP id y186so4890855yby.10 for ; Sat, 05 Nov 2022 14:13:31 -0700 (PDT) X-Received: by 2002:a05:6902:1352:b0:6bb:3f4b:9666 with SMTP id g18-20020a056902135200b006bb3f4b9666mr38314227ybu.101.1667682810745; Sat, 05 Nov 2022 14:13:30 -0700 (PDT) MIME-Version: 1.0 References: <20221105060024.598488967@goodmis.org> <20221105123642.596371c7@rorschach.local.home> In-Reply-To: From: Linus Torvalds Date: Sat, 5 Nov 2022 14:13:14 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers To: "Jason A. Donenfeld" Cc: Steven Rostedt , linux-kernel@vger.kernel.org, Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , rcu@vger.kernel.org, linux-doc@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-edac@vger.kernel.org, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-acpi@vger.kernel.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-pm@vger.kernel.org, drbd-dev@lists.linbit.com, linux-bluetooth@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, intel-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-parisc@vger.kernel.org, linux-leds@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, linux-ext4@vger.kernel.org, linux-nilfs@vger.kernel.org, bridge@lists.linux-foundation.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, lvs-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, tipc-discussion@lists.sourceforge.net, alsa-devel@alsa-project.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Sat, Nov 5, 2022 at 2:03 PM Jason A. Donenfeld wrote: > > Something that might help here is changing the `...` into > `... when exists` or into `... when != ptr` or similar. I actually tried that. You don't want "when exists", you'd want "when forall", but that seems to be the default. And trying "when != ptr->timer" actually does the right thing in that it gets rid of the case where the timer is modified outside of the del_timer() case, *but* it also causes odd other changes to the output. Look at what it generates for that drivers/media/usb/pvrusb2/pvrusb2-hdw.c file, which finds a lot of triggers with the "when != ptr->timer", but only does one without it. So I gave up, just because I clearly don't understand the rules. (Comparing output is also fun because the ordering of the patches is random, so consecutive runs with the same rule will give different patches. I assume that it's just because it's done in parallel, but it doesn't help the "try to see what changes when you change the script" ;) Linus