linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sh: Add missing FORCE prerequisites in Makefile
@ 2021-09-16  8:43 Geert Uytterhoeven
  2021-09-19  2:02 ` Masahiro Yamada
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-09-16  8:43 UTC (permalink / raw)
  To: Masahiro Yamada, Yoshinori Sato, Rich Felker
  Cc: linux-sh, linux-kbuild, linux-kernel, Geert Uytterhoeven

make:

    arch/sh/boot/Makefile:87: FORCE prerequisite is missing

Add the missing FORCE prerequisites for all build targets identified by
"make help".

Fixes: e1f86d7b4b2a5213 ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and filechk")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/sh/boot/Makefile | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/sh/boot/Makefile b/arch/sh/boot/Makefile
index dded61296c9a00da..5c123f5b2797c08a 100644
--- a/arch/sh/boot/Makefile
+++ b/arch/sh/boot/Makefile
@@ -80,30 +80,30 @@ $(obj)/vmlinux.bin.xz: $(obj)/vmlinux.bin FORCE
 $(obj)/vmlinux.bin.lzo: $(obj)/vmlinux.bin FORCE
 	$(call if_changed,lzo)
 
-$(obj)/uImage.bz2: $(obj)/vmlinux.bin.bz2
+$(obj)/uImage.bz2: $(obj)/vmlinux.bin.bz2 FORCE
 	$(call if_changed,uimage,bzip2)
 
-$(obj)/uImage.gz: $(obj)/vmlinux.bin.gz
+$(obj)/uImage.gz: $(obj)/vmlinux.bin.gz FORCE
 	$(call if_changed,uimage,gzip)
 
-$(obj)/uImage.lzma: $(obj)/vmlinux.bin.lzma
+$(obj)/uImage.lzma: $(obj)/vmlinux.bin.lzma FORCE
 	$(call if_changed,uimage,lzma)
 
-$(obj)/uImage.xz: $(obj)/vmlinux.bin.xz
+$(obj)/uImage.xz: $(obj)/vmlinux.bin.xz FORCE
 	$(call if_changed,uimage,xz)
 
-$(obj)/uImage.lzo: $(obj)/vmlinux.bin.lzo
+$(obj)/uImage.lzo: $(obj)/vmlinux.bin.lzo FORCE
 	$(call if_changed,uimage,lzo)
 
-$(obj)/uImage.bin: $(obj)/vmlinux.bin
+$(obj)/uImage.bin: $(obj)/vmlinux.bin FORCE
 	$(call if_changed,uimage,none)
 
 OBJCOPYFLAGS_vmlinux.srec := -I binary -O srec
-$(obj)/vmlinux.srec: $(obj)/compressed/vmlinux
+$(obj)/vmlinux.srec: $(obj)/compressed/vmlinux FORCE
 	$(call if_changed,objcopy)
 
 OBJCOPYFLAGS_uImage.srec := -I binary -O srec
-$(obj)/uImage.srec: $(obj)/uImage
+$(obj)/uImage.srec: $(obj)/uImage FORCE
 	$(call if_changed,objcopy)
 
 $(obj)/uImage: $(obj)/uImage.$(suffix-y)
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] sh: Add missing FORCE prerequisites in Makefile
  2021-09-16  8:43 [PATCH] sh: Add missing FORCE prerequisites in Makefile Geert Uytterhoeven
@ 2021-09-19  2:02 ` Masahiro Yamada
  0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2021-09-19  2:02 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Yoshinori Sato, Rich Felker, Linux-sh list,
	Linux Kbuild mailing list, Linux Kernel Mailing List

On Thu, Sep 16, 2021 at 5:43 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> make:
>
>     arch/sh/boot/Makefile:87: FORCE prerequisite is missing
>
> Add the missing FORCE prerequisites for all build targets identified by
> "make help".
>
> Fixes: e1f86d7b4b2a5213 ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and filechk")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---


Applied to linux-kbuild. Thanks.

>  arch/sh/boot/Makefile | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/sh/boot/Makefile b/arch/sh/boot/Makefile
> index dded61296c9a00da..5c123f5b2797c08a 100644
> --- a/arch/sh/boot/Makefile
> +++ b/arch/sh/boot/Makefile
> @@ -80,30 +80,30 @@ $(obj)/vmlinux.bin.xz: $(obj)/vmlinux.bin FORCE
>  $(obj)/vmlinux.bin.lzo: $(obj)/vmlinux.bin FORCE
>         $(call if_changed,lzo)
>
> -$(obj)/uImage.bz2: $(obj)/vmlinux.bin.bz2
> +$(obj)/uImage.bz2: $(obj)/vmlinux.bin.bz2 FORCE
>         $(call if_changed,uimage,bzip2)
>
> -$(obj)/uImage.gz: $(obj)/vmlinux.bin.gz
> +$(obj)/uImage.gz: $(obj)/vmlinux.bin.gz FORCE
>         $(call if_changed,uimage,gzip)
>
> -$(obj)/uImage.lzma: $(obj)/vmlinux.bin.lzma
> +$(obj)/uImage.lzma: $(obj)/vmlinux.bin.lzma FORCE
>         $(call if_changed,uimage,lzma)
>
> -$(obj)/uImage.xz: $(obj)/vmlinux.bin.xz
> +$(obj)/uImage.xz: $(obj)/vmlinux.bin.xz FORCE
>         $(call if_changed,uimage,xz)
>
> -$(obj)/uImage.lzo: $(obj)/vmlinux.bin.lzo
> +$(obj)/uImage.lzo: $(obj)/vmlinux.bin.lzo FORCE
>         $(call if_changed,uimage,lzo)
>
> -$(obj)/uImage.bin: $(obj)/vmlinux.bin
> +$(obj)/uImage.bin: $(obj)/vmlinux.bin FORCE
>         $(call if_changed,uimage,none)
>
>  OBJCOPYFLAGS_vmlinux.srec := -I binary -O srec
> -$(obj)/vmlinux.srec: $(obj)/compressed/vmlinux
> +$(obj)/vmlinux.srec: $(obj)/compressed/vmlinux FORCE
>         $(call if_changed,objcopy)
>
>  OBJCOPYFLAGS_uImage.srec := -I binary -O srec
> -$(obj)/uImage.srec: $(obj)/uImage
> +$(obj)/uImage.srec: $(obj)/uImage FORCE
>         $(call if_changed,objcopy)
>
>  $(obj)/uImage: $(obj)/uImage.$(suffix-y)
> --
> 2.25.1
>


-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-19  2:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16  8:43 [PATCH] sh: Add missing FORCE prerequisites in Makefile Geert Uytterhoeven
2021-09-19  2:02 ` Masahiro Yamada

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).