From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Guo Ren <guoren@kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-csky@vger.kernel.org
Subject: Re: [PATCH 1/3] sh: Cleanup about SPARSE_IRQ
Date: Mon, 27 Sep 2021 16:29:40 +0200 [thread overview]
Message-ID: <CAMuHMdUC9FtGhXCQFTsGVf3yfX=WUZ4V30SGL9BzgAhOMYaH_A@mail.gmail.com> (raw)
In-Reply-To: <20210927081402.191717-2-wangkefeng.wang@huawei.com>
Hi Kefeng,
On Mon, Sep 27, 2021 at 10:11 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> After commit 37744feebc08 ("sh: remove sh5 support"), sh always
> enable SPARSE_IRQ, kill unused MAY_HAVE_SPARSE_IRQ and NR_IRQS
> define under !CONFIG_SPARSE_IRQ.
>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
One question below...
> --- a/arch/sh/include/asm/irq.h
> +++ b/arch/sh/include/asm/irq.h
> @@ -5,16 +5,7 @@
> #include <linux/cpumask.h>
> #include <asm/machvec.h>
>
> -/*
> - * Only legacy non-sparseirq platforms have to set a reasonably sane
> - * value here. sparseirq platforms allocate their irq_descs on the fly,
> - * so will expand automatically based on the number of registered IRQs.
> - */
> -#ifdef CONFIG_SPARSE_IRQ
> # define NR_IRQS 8
> -#else
> -# define NR_IRQS 512
> -#endif
I'm wondering if we can go even further, and just remove the definition
of NR_IRQS, and fall back to the default in include/asm-generic/irq.h?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-09-27 14:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 8:13 [PATCH 0/3] Cleanup MAY_HAVE_SPARSE_IRQ Kefeng Wang
2021-09-27 8:14 ` [PATCH 1/3] sh: Cleanup about SPARSE_IRQ Kefeng Wang
2021-09-27 14:29 ` Geert Uytterhoeven [this message]
2021-09-27 8:14 ` [PATCH 2/3] csky: Use SPARSE_IRQ Kefeng Wang
2021-09-28 3:39 ` Guo Ren
2021-09-28 4:47 ` Kefeng Wang
2021-09-27 8:14 ` [PATCH 3/3] genirq: Cleanup Kconfig Kefeng Wang
2021-09-27 12:09 ` [PATCH 0/3] Cleanup MAY_HAVE_SPARSE_IRQ Guo Ren
2021-09-27 12:35 ` Kefeng Wang
2021-09-27 14:08 ` Guo Ren
2021-09-28 5:08 ` Guo Ren
2021-09-28 5:43 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUC9FtGhXCQFTsGVf3yfX=WUZ4V30SGL9BzgAhOMYaH_A@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=dalias@libc.org \
--cc=guoren@kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wangkefeng.wang@huawei.com \
--cc=ysato@users.sourceforge.jp \
--subject='Re: [PATCH 1/3] sh: Cleanup about SPARSE_IRQ' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).