From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Takashi YOSHII <takasi-y@ops.dti.ne.jp>
Subject: Re: [PATCH 3/5 v3] sh: math-emu: drop unused functions
Date: Tue, 5 Oct 2021 09:26:06 +0200 [thread overview]
Message-ID: <CAMuHMdUwkOwLgbxjSwO0QCq+=jBL+e1z8X6NZHrrx0bv_zFq1A@mail.gmail.com> (raw)
In-Reply-To: <20211005001914.28574-4-rdunlap@infradead.org>
Hi Randy,
Thanks for your patch!
On Tue, Oct 5, 2021 at 2:19 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Delete ieee_fpe_handler() since it is not used. After that is done,
> delete denormal_to_double() since it is not used:
>
> ../arch/sh/math-emu/math.c:505:12: error: 'ieee_fpe_handler' defined but not used [-Werror=unused-function]
> 505 | static int ieee_fpe_handler(struct pt_regs *regs)
>
> ../arch/sh/math-emu/math.c:477:13: error: 'denormal_to_double' defined but not used [-Werror=unused-function]
> 477 | static void denormal_to_double(struct sh_fpu_soft_struct *fpu, int n)
>
> Fixes: 4b565680d163 ("sh: math-emu support")
Shouldn't that be
Fixes: 7caf62de25554da3 ("sh: remove unused do_fpu_error")
?
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-10-05 7:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 0:19 [PATCH 0/5 v3] sh: fixes for various build and kconfig warnings Randy Dunlap
2021-10-05 0:19 ` [PATCH 1/5 v3] sh: fix kconfig unmet dependency warning for FRAME_POINTER Randy Dunlap
2021-10-05 0:19 ` [PATCH 2/5 v3] sh: add git tree to MAINTAINERS Randy Dunlap
2021-10-05 7:21 ` Geert Uytterhoeven
2021-10-27 20:54 ` Rich Felker
2021-10-28 8:33 ` Geert Uytterhoeven
2021-10-28 13:30 ` Rich Felker
2021-10-28 13:37 ` Geert Uytterhoeven
2021-11-01 19:10 ` Konstantin Ryabitsev
2021-10-05 0:19 ` [PATCH 3/5 v3] sh: math-emu: drop unused functions Randy Dunlap
2021-10-05 7:26 ` Geert Uytterhoeven [this message]
2021-10-06 1:06 ` Randy Dunlap
2021-10-05 0:19 ` [PATCH 4/5 v3] sh: define __BIG_ENDIAN for math-emu Randy Dunlap
2021-10-05 0:19 ` [PATCH 5/5 v3] sh: fix READ/WRITE redefinition warnings Randy Dunlap
2021-10-08 18:39 ` Rob Landley
2021-10-08 19:46 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUwkOwLgbxjSwO0QCq+=jBL+e1z8X6NZHrrx0bv_zFq1A@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=dalias@libc.org \
--cc=geert+renesas@glider.be \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=takasi-y@ops.dti.ne.jp \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).