From: Geert Uytterhoeven <geert@linux-m68k.org>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 6/7 v5] sh: fix Kconfig entry for NUMA => SMP
Date: Tue, 21 Mar 2023 09:47:31 +0100 [thread overview]
Message-ID: <CAMuHMdV-hAcf+uaWvLdXef6jOUHWV04u0FS2dGHxtJArG6c_Wg@mail.gmail.com> (raw)
In-Reply-To: <fa8b4f3ca8f3d9dc0487399962bcc6ef75ebd6b0.camel@physik.fu-berlin.de>
Hi Adrian,
On Tue, Mar 21, 2023 at 9:45 AM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
> On Tue, 2023-03-21 at 09:42 +0100, Geert Uytterhoeven wrote:
> > On Tue, Mar 21, 2023 at 9:10 AM John Paul Adrian Glaubitz
> > <glaubitz@physik.fu-berlin.de> wrote:
> > > On Tue, 2023-03-21 at 08:55 +0100, Geert Uytterhoeven wrote:
> > > > On Tue, Mar 21, 2023 at 12:13 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> > > > > Fix SUPERH builds that select SYS_SUPPORTS_NUMA but do not select
> > > > > SYS_SUPPORTS_SMP and SMP.
> > > >
> > > > Perhaps because these SoCs do not support SMP?
> > >
> > > Well, there is actually a dual-core 7786 board available, see:
> > >
> > > > https://www.apnet.co.jp/product/superh/ap-sh4ad-0a.html
> > >
> > > Quoting:
> > >
> > > »The SH7786 is equipped with a dual-core SH-4A and has interfaces such as
> > > DDR3 SDRAM, PCI Express, USB, and display unit.«
> >
> > SH7786 is dual-core...
> >
> > > FWIW, I just realized we need this for config CPU_SUBTYPE_SH7786 as well.
> >
> > ... and CPU_SUBTYPE_SH7786 selects CPU_SHX3, which selects
> > SYS_SUPPORTS_SMP and SYS_SUPPORTS_NUMA in turn.
> > So everything is fine for SH7786.
>
> Yeah, this explains it then. Your new patch is definitely the better approach
> and I would prefer it over Randy's suggested change. Let's see what the mm
> maintainers have to say.
I'm sure the missed condition was just an oversight, so I expect no
objections.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2023-03-21 8:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 23:13 [PATCH 6/7 v5] sh: fix Kconfig entry for NUMA => SMP Randy Dunlap
2023-03-21 7:55 ` Geert Uytterhoeven
2023-03-21 8:10 ` John Paul Adrian Glaubitz
2023-03-21 8:19 ` Geert Uytterhoeven
2023-03-21 8:32 ` Geert Uytterhoeven
2023-03-21 8:38 ` D. Jeff Dionne
2023-03-21 8:42 ` Geert Uytterhoeven
2023-03-21 8:45 ` John Paul Adrian Glaubitz
2023-03-21 8:47 ` Geert Uytterhoeven [this message]
2023-03-21 15:15 ` John Paul Adrian Glaubitz
2023-03-21 15:16 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdV-hAcf+uaWvLdXef6jOUHWV04u0FS2dGHxtJArG6c_Wg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=dalias@libc.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=stable@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).