linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* (no subject)
@ 2021-08-16  5:59 zhao xc
  2021-08-16  7:04 ` Patch formatting - John Paul Adrian Glaubitz
  0 siblings, 1 reply; 3+ messages in thread
From: zhao xc @ 2021-08-16  5:59 UTC (permalink / raw)
  To: ysato; +Cc: dalias, linux-sh, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: 0001-CONFIG_IP_NF_TARGET_LOG-Configuration-does-not-exist.patch --]
[-- Type: text/x-patch, Size: 838 bytes --]

From f7a2abd1c4ce4f46d955b1fa00063113352de39b Mon Sep 17 00:00:00 2001
From: zhaoxinchao <xinchao.zhao@ucas.com.cn>
Date: Sun, 15 Aug 2021 20:35:16 -0700
Subject: [PATCH] CONFIG_IP_NF_TARGET_LOG Configuration does not exist

Signed-off-by: zhaoxinchao <xinchao.zhao@ucas.com.cn>
---
 arch/sh/configs/titan_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sh/configs/titan_defconfig b/arch/sh/configs/titan_defconfig
index ba887f1351be..a8b4a9d393be 100644
--- a/arch/sh/configs/titan_defconfig
+++ b/arch/sh/configs/titan_defconfig
@@ -83,7 +83,7 @@ CONFIG_IP_NF_MATCH_ECN=m
 CONFIG_IP_NF_MATCH_TTL=m
 CONFIG_IP_NF_FILTER=m
 CONFIG_IP_NF_TARGET_REJECT=m
-CONFIG_IP_NF_TARGET_LOG=m
+CONFIG_NETFILTER_XT_TARGET_LOG=m
 CONFIG_IP_NF_MANGLE=m
 CONFIG_IP_NF_TARGET_ECN=m
 CONFIG_IP_NF_TARGET_TTL=m
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Patch formatting - Re:
  2021-08-16  5:59 zhao xc
@ 2021-08-16  7:04 ` John Paul Adrian Glaubitz
  2021-08-16  7:22   ` Willy Tarreau
  0 siblings, 1 reply; 3+ messages in thread
From: John Paul Adrian Glaubitz @ 2021-08-16  7:04 UTC (permalink / raw)
  To: zhao xc, ysato; +Cc: dalias, linux-sh, linux-kernel

Hi Zhao!

Thanks for your patch!

However, the patch has not been properly formatted and needs to be resend.

Could you follow this guide [1] and send your patch again in the correct
format?

Thanks,
Adrian

> [1] http://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Patch formatting - Re:
  2021-08-16  7:04 ` Patch formatting - John Paul Adrian Glaubitz
@ 2021-08-16  7:22   ` Willy Tarreau
  0 siblings, 0 replies; 3+ messages in thread
From: Willy Tarreau @ 2021-08-16  7:22 UTC (permalink / raw)
  To: John Paul Adrian Glaubitz; +Cc: zhao xc, ysato, dalias, linux-sh, linux-kernel

On Mon, Aug 16, 2021 at 09:04:57AM +0200, John Paul Adrian Glaubitz wrote:
> Hi Zhao!
> 
> Thanks for your patch!
> 
> However, the patch has not been properly formatted and needs to be resend.
> 
> Could you follow this guide [1] and send your patch again in the correct
> format?

Adrian, it would be nice to give some hints about what has to be fixed,
because it's not necessarily easy to be able to figure this by comparing
one's patch to an example in a blog article.

Zhao, some hints:
  - the subject line doesn't make it obvious what subsystem is being touched.
    Often running "git log" on the file(s) you change can help you figure what
    others commonly use ;

  - the commit message is empty, it should carry a description of what you
    are trying to improve or fix, and when relevant, some indications about
    how you decided to address that. A good hint is to think that you're
    trying to "sell" your patch to someone else who will become responsible
    for maintaining it, thus put all the selling arguments there :-)

  - often a Cc list is desired if it touches areas that may impact others,
    as well as their maintainers ;

  - using git-send-email like in the article is generally preferred as it
    makes the process smoother on the receiver's end. It can look scary
    at first, making you fear to accidentally send poorly formatted
    e-mails, but in practice it's rare, and recipients are used to seeing
    this and are very tolerant to this :-)

And yes, reading Nick's article is definitely a good idea!

> Thanks,
> Adrian

Regards,
Willy

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-16  7:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16  5:59 zhao xc
2021-08-16  7:04 ` Patch formatting - John Paul Adrian Glaubitz
2021-08-16  7:22   ` Willy Tarreau

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).