linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 18/20] kbuild: sh: remove unused install script
       [not found] <20210407053419.449796-1-gregkh@linuxfoundation.org>
@ 2021-04-07  5:34 ` Greg Kroah-Hartman
  2021-04-09  3:09   ` Kees Cook
  2021-08-24 15:22   ` Masahiro Yamada
  0 siblings, 2 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-04-07  5:34 UTC (permalink / raw)
  To: Masahiro Yamada, Michal Marek
  Cc: linux-kbuild, linux-arch, linux-kernel, Greg Kroah-Hartman,
	Yoshinori Sato, Rich Felker, linux-sh

The sh arch has a install.sh script, but no Makefile actually calls it.
Remove it to keep anyone from accidentally calling it in the future.

Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 arch/sh/boot/compressed/install.sh | 56 ------------------------------
 1 file changed, 56 deletions(-)
 delete mode 100644 arch/sh/boot/compressed/install.sh

diff --git a/arch/sh/boot/compressed/install.sh b/arch/sh/boot/compressed/install.sh
deleted file mode 100644
index f9f41818b17e..000000000000
--- a/arch/sh/boot/compressed/install.sh
+++ /dev/null
@@ -1,56 +0,0 @@
-#!/bin/sh
-#
-# arch/sh/boot/install.sh
-#
-# This file is subject to the terms and conditions of the GNU General Public
-# License.  See the file "COPYING" in the main directory of this archive
-# for more details.
-#
-# Copyright (C) 1995 by Linus Torvalds
-#
-# Adapted from code in arch/i386/boot/Makefile by H. Peter Anvin
-# Adapted from code in arch/i386/boot/install.sh by Russell King
-# Adapted from code in arch/arm/boot/install.sh by Stuart Menefy
-#
-# "make install" script for sh architecture
-#
-# Arguments:
-#   $1 - kernel version
-#   $2 - kernel image file
-#   $3 - kernel map file
-#   $4 - default install path (blank if root directory)
-#
-
-# User may have a custom install script
-
-if [ -x /sbin/${INSTALLKERNEL} ]; then
-  exec /sbin/${INSTALLKERNEL} "$@"
-fi
-
-if [ "$2" = "zImage" ]; then
-# Compressed install
-  echo "Installing compressed kernel"
-  if [ -f $4/vmlinuz-$1 ]; then
-    mv $4/vmlinuz-$1 $4/vmlinuz.old
-  fi
-
-  if [ -f $4/System.map-$1 ]; then
-    mv $4/System.map-$1 $4/System.old
-  fi
-
-  cat $2 > $4/vmlinuz-$1
-  cp $3 $4/System.map-$1
-else
-# Normal install
-  echo "Installing normal kernel"
-  if [ -f $4/vmlinux-$1 ]; then
-    mv $4/vmlinux-$1 $4/vmlinux.old
-  fi
-
-  if [ -f $4/System.map ]; then
-    mv $4/System.map $4/System.old
-  fi
-
-  cat $2 > $4/vmlinux-$1
-  cp $3 $4/System.map
-fi
-- 
2.31.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 18/20] kbuild: sh: remove unused install script
  2021-04-07  5:34 ` [PATCH 18/20] kbuild: sh: remove unused install script Greg Kroah-Hartman
@ 2021-04-09  3:09   ` Kees Cook
  2021-08-24 15:22   ` Masahiro Yamada
  1 sibling, 0 replies; 4+ messages in thread
From: Kees Cook @ 2021-04-09  3:09 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Masahiro Yamada, Michal Marek, linux-kbuild, linux-arch,
	linux-kernel, Yoshinori Sato, Rich Felker, linux-sh

On Wed, Apr 07, 2021 at 07:34:17AM +0200, Greg Kroah-Hartman wrote:
> The sh arch has a install.sh script, but no Makefile actually calls it.
> Remove it to keep anyone from accidentally calling it in the future.
> 
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>
> Cc: linux-sh@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 18/20] kbuild: sh: remove unused install script
  2021-04-07  5:34 ` [PATCH 18/20] kbuild: sh: remove unused install script Greg Kroah-Hartman
  2021-04-09  3:09   ` Kees Cook
@ 2021-08-24 15:22   ` Masahiro Yamada
  2021-08-27 14:02     ` Greg Kroah-Hartman
  1 sibling, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2021-08-24 15:22 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Michal Marek, Linux Kbuild mailing list, linux-arch,
	Linux Kernel Mailing List, Yoshinori Sato, Rich Felker,
	Linux-sh list

On Wed, Apr 7, 2021 at 2:35 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> The sh arch has a install.sh script, but no Makefile actually calls it.
> Remove it to keep anyone from accidentally calling it in the future.
>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>
> Cc: linux-sh@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  arch/sh/boot/compressed/install.sh | 56 ------------------------------
>  1 file changed, 56 deletions(-)
>  delete mode 100644 arch/sh/boot/compressed/install.sh
>
> diff --git a/arch/sh/boot/compressed/install.sh b/arch/sh/boot/compressed/install.sh
> deleted file mode 100644
> index f9f41818b17e..000000000000
> --- a/arch/sh/boot/compressed/install.sh
> +++ /dev/null
> @@ -1,56 +0,0 @@
> -#!/bin/sh
> -#
> -# arch/sh/boot/install.sh
> -#
> -# This file is subject to the terms and conditions of the GNU General Public
> -# License.  See the file "COPYING" in the main directory of this archive
> -# for more details.
> -#
> -# Copyright (C) 1995 by Linus Torvalds
> -#
> -# Adapted from code in arch/i386/boot/Makefile by H. Peter Anvin
> -# Adapted from code in arch/i386/boot/install.sh by Russell King
> -# Adapted from code in arch/arm/boot/install.sh by Stuart Menefy
> -#
> -# "make install" script for sh architecture
> -#
> -# Arguments:
> -#   $1 - kernel version
> -#   $2 - kernel image file
> -#   $3 - kernel map file
> -#   $4 - default install path (blank if root directory)
> -#
> -
> -# User may have a custom install script
> -
> -if [ -x /sbin/${INSTALLKERNEL} ]; then
> -  exec /sbin/${INSTALLKERNEL} "$@"
> -fi
> -
> -if [ "$2" = "zImage" ]; then
> -# Compressed install
> -  echo "Installing compressed kernel"
> -  if [ -f $4/vmlinuz-$1 ]; then
> -    mv $4/vmlinuz-$1 $4/vmlinuz.old
> -  fi
> -
> -  if [ -f $4/System.map-$1 ]; then
> -    mv $4/System.map-$1 $4/System.old
> -  fi
> -
> -  cat $2 > $4/vmlinuz-$1
> -  cp $3 $4/System.map-$1
> -else
> -# Normal install
> -  echo "Installing normal kernel"
> -  if [ -f $4/vmlinux-$1 ]; then
> -    mv $4/vmlinux-$1 $4/vmlinux.old
> -  fi
> -
> -  if [ -f $4/System.map ]; then
> -    mv $4/System.map $4/System.old
> -  fi
> -
> -  cat $2 > $4/vmlinux-$1
> -  cp $3 $4/System.map
> -fi
> --
> 2.31.1
>


This one is applicable independently.

Applied to linux-kbuild. Thanks.



-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 18/20] kbuild: sh: remove unused install script
  2021-08-24 15:22   ` Masahiro Yamada
@ 2021-08-27 14:02     ` Greg Kroah-Hartman
  0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-08-27 14:02 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Michal Marek, Linux Kbuild mailing list, linux-arch,
	Linux Kernel Mailing List, Yoshinori Sato, Rich Felker,
	Linux-sh list

On Wed, Aug 25, 2021 at 12:22:03AM +0900, Masahiro Yamada wrote:
> On Wed, Apr 7, 2021 at 2:35 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > The sh arch has a install.sh script, but no Makefile actually calls it.
> > Remove it to keep anyone from accidentally calling it in the future.
> >
> > Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> > Cc: Rich Felker <dalias@libc.org>
> > Cc: linux-sh@vger.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> >  arch/sh/boot/compressed/install.sh | 56 ------------------------------
> >  1 file changed, 56 deletions(-)
> >  delete mode 100644 arch/sh/boot/compressed/install.sh
> >
> > diff --git a/arch/sh/boot/compressed/install.sh b/arch/sh/boot/compressed/install.sh
> > deleted file mode 100644
> > index f9f41818b17e..000000000000
> > --- a/arch/sh/boot/compressed/install.sh
> > +++ /dev/null
> > @@ -1,56 +0,0 @@
> > -#!/bin/sh
> > -#
> > -# arch/sh/boot/install.sh
> > -#
> > -# This file is subject to the terms and conditions of the GNU General Public
> > -# License.  See the file "COPYING" in the main directory of this archive
> > -# for more details.
> > -#
> > -# Copyright (C) 1995 by Linus Torvalds
> > -#
> > -# Adapted from code in arch/i386/boot/Makefile by H. Peter Anvin
> > -# Adapted from code in arch/i386/boot/install.sh by Russell King
> > -# Adapted from code in arch/arm/boot/install.sh by Stuart Menefy
> > -#
> > -# "make install" script for sh architecture
> > -#
> > -# Arguments:
> > -#   $1 - kernel version
> > -#   $2 - kernel image file
> > -#   $3 - kernel map file
> > -#   $4 - default install path (blank if root directory)
> > -#
> > -
> > -# User may have a custom install script
> > -
> > -if [ -x /sbin/${INSTALLKERNEL} ]; then
> > -  exec /sbin/${INSTALLKERNEL} "$@"
> > -fi
> > -
> > -if [ "$2" = "zImage" ]; then
> > -# Compressed install
> > -  echo "Installing compressed kernel"
> > -  if [ -f $4/vmlinuz-$1 ]; then
> > -    mv $4/vmlinuz-$1 $4/vmlinuz.old
> > -  fi
> > -
> > -  if [ -f $4/System.map-$1 ]; then
> > -    mv $4/System.map-$1 $4/System.old
> > -  fi
> > -
> > -  cat $2 > $4/vmlinuz-$1
> > -  cp $3 $4/System.map-$1
> > -else
> > -# Normal install
> > -  echo "Installing normal kernel"
> > -  if [ -f $4/vmlinux-$1 ]; then
> > -    mv $4/vmlinux-$1 $4/vmlinux.old
> > -  fi
> > -
> > -  if [ -f $4/System.map ]; then
> > -    mv $4/System.map $4/System.old
> > -  fi
> > -
> > -  cat $2 > $4/vmlinux-$1
> > -  cp $3 $4/System.map
> > -fi
> > --
> > 2.31.1
> >
> 
> 
> This one is applicable independently.
> 
> Applied to linux-kbuild. Thanks.

Hey, nice, thanks!

I'll work on the rest of the patches in this series after the next merge
window is over...

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-27 14:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210407053419.449796-1-gregkh@linuxfoundation.org>
2021-04-07  5:34 ` [PATCH 18/20] kbuild: sh: remove unused install script Greg Kroah-Hartman
2021-04-09  3:09   ` Kees Cook
2021-08-24 15:22   ` Masahiro Yamada
2021-08-27 14:02     ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).