archive mirror
 help / color / mirror / Atom feed
From: Rob Landley <>
To: Geert Uytterhoeven <>
Cc: Yoshinori Sato <>,
	Rich Felker <>,
	"Aneesh Kumar K . V" <>,
	Andrew Morton <>,
	Jacopo Mondi <>,
	Daniel Palmer <>,
	Linux-sh list <>,
	Linux MM <>,
	Linux Kernel Mailing List <>
Subject: Re: [PATCH] sh: pgtable-3level: Fix cast to pointer from integer of different size
Date: Sat, 18 Sep 2021 00:04:50 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 9/17/21 4:21 AM, Geert Uytterhoeven wrote:
> Hi Rob,
> On Fri, Sep 17, 2021 at 3:12 AM Rob Landley <> wrote:
>> On 9/15/21 8:50 AM, Geert Uytterhoeven wrote:
>> >     arch/sh/include/asm/pgtable-3level.h:37:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>> ...
>> > The truncation to "unsigned long" has been there since forever, so
>> > probably it still works fine ;-)
>> 1) Linux is LP64 so sizeof(long) and sizeof(pointer) always match, so it's not
>> truncating.
>> 2) The sh5 only ever shipped evaluation units, it never had a production run,
>> and we haven't implemented j64 yet, so all superh targets are currently 32 bit.
>> (I.E. it's complaining about _expanding_ the pointer, which shouldn't be a
>> problem as long as endianness is respected.)
> The build error is for 32-bit.

I know. I'm just saying your fix doesn't seem wrong. (Personally I would have
just cast once to (void *) and let C not being C++ do the right thing, but eh...)

Not sure I understand the point of the original code though. Under what
conditions do you want 64 bit page tables on a 32 bit system? (Some PAE variant?)

> If CONFIG_X2TLB=y, pgd_t.pgd is "unsigned long long", i.e. 64-bit, so
> casting it to a pointer needs an intermediate cast to "unsigned long".
> See arch/sh/include/asm/page.h:

I can't find a user of it. None of the existing defconfigs select this option:

  $ grep -r X2TLB arch/sh/configs

And it's weird in other ways, like 8k page size. (Why...?)

Google finds sh-x2 mentioned in Renesas' sh4a debugger docs, but I've never
played with the renesas "a" variants. The stuff I'm familiar with is all
following up on what Hitachi did, not Renesas.

*shrug* You fix looks good enough to me.

Acked-by: Rob Landley <>


  reply	other threads:[~2021-09-18  4:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 13:50 Geert Uytterhoeven
2021-09-15 13:58 ` Daniel Palmer
2021-09-16 12:06 ` Daniel Palmer
2021-09-17  1:32 ` Rob Landley
2021-09-17  9:21   ` Geert Uytterhoeven
2021-09-18  5:04     ` Rob Landley [this message]
2021-09-18 11:20       ` Geert Uytterhoeven
2021-09-23 15:20 ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] sh: pgtable-3level: Fix cast to pointer from integer of different size' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).